Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v0.0.0 in kubectl built from master #42623

Merged
merged 1 commit into from
Mar 13, 2017
Merged

Fix v0.0.0 in kubectl built from master #42623

merged 1 commit into from
Mar 13, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 7, 2017

Fixes #40813

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 7, 2017
@liggitt liggitt mentioned this pull request Mar 7, 2017
Closed
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 7, 2017
@caesarxuchao
Copy link
Member

It doesn't work for me. I played with other vendored package, it looks like ldflags doesn't work for code in vendor/ in general.

@caesarxuchao
Copy link
Member

Eh, the trick is to make clean first.

@caesarxuchao caesarxuchao added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2017
@liggitt liggitt added this to the v1.7 milestone Mar 11, 2017
@mengqiy
Copy link
Member

mengqiy commented Mar 13, 2017

@liggitt Why this small fix is not for 1.6 but the issue #40813 is for 1.6?

@caesarxuchao caesarxuchao modified the milestones: v1.6, v1.7 Mar 13, 2017
@caesarxuchao
Copy link
Member

I think it's 1.6. Updated the label.

Thanks @ymqytw for noticing this.

@caesarxuchao
Copy link
Member

@zmerlynn could you approve the change? Thanks.

@liggitt
Copy link
Member Author

liggitt commented Mar 13, 2017

@liggitt Why this small fix is not for 1.6 but the issue #40813 is for 1.6?

I wouldn't consider it release-blocking, since the official release doesn't have this problem, but it wouldn't bother me if it went in.

@zmerlynn
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: liggitt, zmerlynn

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5e29e1e into kubernetes:master Mar 13, 2017
@liggitt liggitt deleted the kubectl-version branch March 17, 2017 01:58
@ixdy ixdy mentioned this pull request May 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@liggitt @k8s-reviewable @caesarxuchao @mengqiy @zmerlynn @k8s-github-robot @k8s-ci-robot