Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples with storage.k8s.io/v1 #42637

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Update examples with storage.k8s.io/v1 #42637

merged 1 commit into from
Mar 7, 2017

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Mar 7, 2017

This should squeeze into 1.6. All changes are in examples directory and reflect our new API.

Release note:

NONE

@kubernetes/sig-storage-pr-reviews

@jsafrane jsafrane added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 7, 2017
@jsafrane jsafrane added this to the v1.6 milestone Mar 7, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@childsb childsb mentioned this pull request Mar 7, 2017
Closed
23 tasks
@gnufied
Copy link
Member

gnufied commented Mar 7, 2017

Looks good to me.

/approve

@zmerlynn
Copy link
Member

zmerlynn commented Mar 7, 2017

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2017
@zmerlynn
Copy link
Member

zmerlynn commented Mar 7, 2017

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: gnufied, jsafrane, zmerlynn

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @brendandburns
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2017
@k8s-ci-robot
Copy link
Contributor

@jsafrane: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins non-CRI GCE e2e 02fbd8a link @k8s-bot non-cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42637, 42648)

@k8s-github-robot k8s-github-robot merged commit dddf7bf into kubernetes:master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jsafrane @k8s-reviewable @gnufied @zmerlynn @k8s-github-robot @k8s-ci-robot