Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ScaleIO volume plugin default readOnly value #42854

Merged
merged 1 commit into from Mar 15, 2017
Merged

Update ScaleIO volume plugin default readOnly value #42854

merged 1 commit into from Mar 15, 2017

Conversation

vladimirvivien
Copy link
Member

This commit updates the code to set readOnly attribute to be set to false.

What this PR does / why we need it:
This PR is a minor fix that updates the default value of readOnly attribute to false.

Release note:

NONE

@k8s-ci-robot
Copy link
Contributor

Hi @vladimirvivien. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 9, 2017
@rootfs
Copy link
Contributor

rootfs commented Mar 10, 2017

@vladimirvivien redirect the PR against master branch

@vladimirvivien
Copy link
Member Author

@rootfs I am trying to get this in 1.6 do I still base against master ? What's the workflow to get changes before code freeze end ?

@rootfs
Copy link
Contributor

rootfs commented Mar 10, 2017

Open a PR to master. Once merged and not in release-1.6, then request a cherry pick.

@vladimirvivien
Copy link
Member Author

@rootfs thanks for the info.

@vladimirvivien vladimirvivien changed the base branch from release-1.6 to master March 10, 2017 21:24
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2017
@vladimirvivien vladimirvivien changed the title Updates ScaleIO readOnly attrib default value to false Update ScaleIO volume plugin default readOnly value Mar 11, 2017
@vladimirvivien
Copy link
Member Author

@k8s-bot ok to test

@k8s-ci-robot
Copy link
Contributor

@vladimirvivien: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot ok to test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rootfs
Copy link
Contributor

rootfs commented Mar 13, 2017

@k8s-bot ok to test

@vladimirvivien
Copy link
Member Author

@k8s-bot gce etcd3 e2e test this

rootfs
rootfs reviewed Mar 13, 2017
View reviewed changes
examples/volumes/scaleio/README.md Outdated
| volumeName| the name of an existing volume in ScaleIO (required)|
| secretRef:name| reference to a configuered Secret object (required, see Secret earlier)|
| readOnly| specifies the access mode to the mounted volume (default `false`)|
| fsType| the file system to use for the volume (default `xfs`)|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also for rest for the patch) this is inconsistent with api doc https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L1091.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootfs Hi, I am not sure what you mean that desc for fsType is inconsistent with the api doc? Are you saying I should copy what's in the API doc in the examples doc ?

Copy link
Contributor

@rootfs rootfs Mar 14, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please make sure the API doc is consistent with README. API doc states ext4 is the default while this patch switches to xfs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootfs the doc and the api is sync'd

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Mar 14, 2017 •
edited

@rootfs can I get a LGTM on this PR so it can be cherry picked for 1.6 please ? Thank you.

@rootfs
Copy link
Contributor

rootfs commented Mar 14, 2017

@vladimirvivien please address the comment and ping me back.

@vladimirvivien
Update ScaleIO volume plugin default readOnly value
0715b32 
This commit updates the code to set the default value of the readOnly attribute to false.
It also updates the example docs to add full list of supported plugin attributes and doc.
@vladimirvivien
Copy link
Member Author

@rootfs ready for another look for a LGTM.

@rootfs
Copy link
Contributor

rootfs commented Mar 14, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: rootfs, vladimirvivien

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @thockin
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@rootfs
Copy link
Contributor

rootfs commented Mar 14, 2017

@vladimirvivien need @thockin approve to get it merged

@saad-ali saad-ali added this to the v1.6 milestone Mar 15, 2017
@saad-ali saad-ali added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 15, 2017
@saad-ali
Copy link
Member

Minor isolated bug fix should be ok for 1.6 post-code freeze merge.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42854, 43105, 43090)

@k8s-github-robot k8s-github-robot merged commit fea42ba into kubernetes:master Mar 15, 2017
@vladimirvivien
Copy link
Member Author

Thank you @rootfs and @saad-ali

@vladimirvivien vladimirvivien deleted the scaleio-k8s-fix-readOnly branch June 7, 2017 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs rootfs left review comments

Assignees

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vladimirvivien @k8s-ci-robot @k8s-reviewable @k8s-github-robot @rootfs @saad-ali