Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log instead of fail on GLBCs tendency to leak resources #43018

Merged
merged 1 commit into from Mar 14, 2017
Merged

Log instead of fail on GLBCs tendency to leak resources #43018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/e2e/framework/ingress_utils.go
View file
Open in desktop
Expand Up @@ -366,9 +366,10 @@ func CleanupGCEIngressController(gceController *GCEIngressController) {
By(fmt.Sprintf("WARNING: possibly leaked static IP: %v\n", ipErr))
}

// Fail if the controller didn't cleanup
// Logging that the GLBC failed to cleanup GCE resources on ingress deletion
// See kubernetes/ingress#431
if pollErr != nil {
Failf("L7 controller failed to delete all cloud resources on time. %v", pollErr)
Logf("error: L7 controller failed to delete all cloud resources on time. %v", pollErr)
}
}

Expand Down