-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring reorganize taints function in kubectl to expose operations #43171
Merged
k8s-github-robot
merged 1 commit into
kubernetes:master
from
ravisantoshgudimetla:kubectl_taints_ux
Apr 20, 2017
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again this whole f(n) belongs elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean somewhere in one of scheduler's packages or api packages? Most of the functions for getting taints are in api/helpers.go. If you want I can move those functions to helpers but I guess those pre-dates my changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this should honestly be a topic of conversation for the sig today. Taints are probably the best example I can think of that has logic sprawl.
There are changes in api, admission, node, scheduler, controllers, kubectl and TBH it needs to be centralized. A change in one area will affect another, in it's current implementation I almost consider it a bug-factory.
/cc @davidopp @gmarek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. We may create a completely separate TaintController controller directory, and move most of the logic there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. There are few predicates and priorities in scheduler especially the ones that are coming from nodeSpec or PodSpec that are difficult to develop as they sprawl different components. Till we have a plan to centralize, we need to create a developer document which tells what all files to touch. If not, it becomes difficult for new developers coming in as they have to look at older PR's to find what files have to be modified.