-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symlink cluster/gce/cos to cluster/gce/gci #43184
Symlink cluster/gce/cos to cluster/gce/gci #43184
Conversation
So scripts that use /etc/os-release.ID as a dir name don't get confused.
@k8s-bot gce etcd3 e2e test this |
@ethernetdan Ack. I will wait to cut beta.4. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, mtaufen, vishh
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 43254, 43255, 43184, 42509) |
Fixes: #43139
As I just unfortunately found out after spending an hour getting to the point where I could test this, upgrade.sh does not support upgrading nodes to local binaries. So someone will have to cut a release to test whether this change actually works.