Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for semantically equal DaemonSet updates #43406

Merged
merged 2 commits into from Apr 12, 2017
Merged

Add tests for semantically equal DaemonSet updates #43406

merged 2 commits into from Apr 12, 2017

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Mar 20, 2017 •
edited

Tests for #43337, depends on #43337. The last commit is already reviewed in #43337.

@liggitt @Kargakis @lukaszo @kubernetes/sig-apps-pr-reviews

@janetkuo janetkuo added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 20, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 20, 2017
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@janetkuo janetkuo mentioned this pull request Mar 20, 2017
Merged
@janetkuo janetkuo assigned lukaszo, liggitt and 0xmichalis and unassigned bprashanth Mar 20, 2017
@janetkuo
Copy link
Member Author

@k8s-bot bazel test this

@janetkuo janetkuo added this to the v1.6 milestone Mar 20, 2017
@0xmichalis
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2017
@janetkuo
Copy link
Member Author

Rebase because #43337 is merged

@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2017
@janetkuo
Copy link
Member Author

@lavalamp would you approve this change?

@enisoc
Copy link
Member

enisoc commented Mar 23, 2017

I'm removing the v1.6 milestone since we are lifting code freeze soon and it doesn't seem like we need to hold the branch cut for this.

@enisoc enisoc modified the milestones: v1.6.1, v1.6 Mar 23, 2017
@liggitt
Copy link
Member

liggitt commented Apr 3, 2017

/lgtm

@janetkuo
Copy link
Member Author

janetkuo commented Apr 6, 2017

Looks like @lavalamp is the only person who can approve this change. Friendly ping

@janetkuo
Copy link
Member Author

@k8s-bot gce etcd3 e2e test this

lavalamp
lavalamp reviewed Apr 11, 2017
View reviewed changes
hack/make-rules/test-cmd-util.sh
@@ -2574,6 +2575,22 @@ run_rs_tests() {
fi
}

run_daemonset_tests() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this tested here? Shouldn't this be a unit test? Is this to test that kubectl doesn't introduce some sort of change? If so please add a comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to catch the original issue #43218. Test it here because [] specified in yaml config will be converted to null.

I have a unit test in validation. Is that not enough?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering if this test adds anything over the unit test you've already put in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. The validation unit test only tests the validation part. I still want to test that after updating a DaemonSet with a semantically equal change, templateGeneration won't change. It can't be done in DaemonSet controller unit test, because templateGeneration is updated by API server but not DaemonSet controller.

@lavalamp
Copy link
Member

This tests one way it could go wrong, do you have plans for testing other ways? or is this good enough?

@lavalamp
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: janetkuo, kargakis, lavalamp, liggitt

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit ebf1439 into kubernetes:master Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

Assignees

@lukaszo lukaszo

@liggitt liggitt

@0xmichalis 0xmichalis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@janetkuo @k8s-reviewable @0xmichalis @enisoc @liggitt @lavalamp @k8s-github-robot @lukaszo @bprashanth @k8s-ci-robot