Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Federation] Add simple upgrade test #43500

Merged
merged 1 commit into from Apr 19, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion hack/.linted_packages
Expand Up @@ -397,7 +397,6 @@ staging/src/k8s.io/kube-aggregator/pkg/controllers
staging/src/k8s.io/sample-apiserver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to rebase your commit? Looks like this should follow through from where it was added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow. All I'm doing here is disabling linting for test/e2e_federation/upgrade so it's possible to dot import ginkgo for the upgrade test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK. I assumed this some sort of automagically-generated updated that didn't get propagated.

staging/src/k8s.io/sample-apiserver/pkg/apis/wardle/install
test/e2e/perftype
test/e2e_federation/upgrades
test/e2e_node/runner/local
test/images/clusterapi-tester
test/images/entrypoint-tester
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_federation/upgrade.go
Expand Up @@ -25,7 +25,7 @@ import (
. "github.com/onsi/ginkgo"
)

var upgradeTests = []upgrades.Test{}
var upgradeTests = upgrades.SimpleUpgradeTests()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we will be adding upgrade tests for more than simple types, please add SimpleUpgradeTests to the upgradeTests slice instead assigning.

Copy link
Contributor Author

@marun marun Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAGNI - whoever ends up adding more types tests can figure out how best to add to the slice.

Also, I'm calling it 'simple' for now, but I anticipate being able to perform upgrade tests generically on all resources by the end of 1.7.


var _ = framework.KubeDescribe("Upgrade [Feature:Upgrade]", func() {
f := fedframework.NewDefaultFederatedFramework("federation-upgrade")
Expand Down
13 changes: 11 additions & 2 deletions test/e2e_federation/upgrades/BUILD
Expand Up @@ -9,9 +9,18 @@ load(

go_library(
name = "go_default_library",
srcs = ["upgrade.go"],
srcs = [
"simple.go",
"upgrade.go",
],
tags = ["automanaged"],
deps = ["//test/e2e_federation/framework:go_default_library"],
deps = [
"//federation/pkg/federatedtypes:go_default_library",
"//federation/pkg/federatedtypes/crudtester:go_default_library",
"//test/e2e_federation/framework:go_default_library",
"//vendor/github.com/onsi/ginkgo:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library",
],
)

filegroup(
Expand Down
72 changes: 72 additions & 0 deletions test/e2e_federation/upgrades/simple.go
@@ -0,0 +1,72 @@
/*
Copyright 2017 The Kubernetes Authors.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package upgrades

import (
"fmt"

pkgruntime "k8s.io/apimachinery/pkg/runtime"
"k8s.io/kubernetes/federation/pkg/federatedtypes"
crudtester "k8s.io/kubernetes/federation/pkg/federatedtypes/crudtester"
fedframework "k8s.io/kubernetes/test/e2e_federation/framework"

. "github.com/onsi/ginkgo"
)

// SimpleUpgradeTest validates that a federated resource remains
// propagated before and after a control plane upgrade
type SimpleUpgradeTest struct {
kind string
adapterFactory federatedtypes.AdapterFactory
crudTester *crudtester.FederatedTypeCRUDTester
obj pkgruntime.Object
}

// Setup creates a resource and validates its propagation to member clusters
func (ut *SimpleUpgradeTest) Setup(f *fedframework.Framework) {
adapter := ut.adapterFactory(f.FederationClientset)
clients := f.GetClusterClients()
ut.crudTester = fedframework.NewFederatedTypeCRUDTester(adapter, clients)

By(fmt.Sprintf("Creating a resource of kind %q and validating propagation to member clusters", ut.kind))
obj := adapter.NewTestObject(f.Namespace.Name)
ut.obj = ut.crudTester.CheckCreate(obj)
}

// Test validates that a resource remains propagated post-upgrade
func (ut *SimpleUpgradeTest) Test(f *fedframework.Framework, done <-chan struct{}, upgrade FederationUpgradeType) {
<-done
By(fmt.Sprintf("Validating that a resource of kind %q remains propagated to member clusters after upgrade", ut.kind))
ut.crudTester.CheckPropagation(ut.obj)
}

// Teardown cleans up remaining resources
func (ut *SimpleUpgradeTest) Teardown(f *fedframework.Framework) {
// Rely on the namespace deletion to clean up everything
}

// SimpleUpgradeTests collects simple upgrade tests for registered federated types
func SimpleUpgradeTests() []Test {
tests := []Test{}
for kind, fedType := range federatedtypes.FederatedTypes() {
tests = append(tests, &SimpleUpgradeTest{
kind: kind,
adapterFactory: fedType.AdapterFactory,
})
}
return tests
}