Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CNI consumers to v0.5.1 #43546

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Bump CNI consumers to v0.5.1 #43546

merged 1 commit into from
Mar 23, 2017

Conversation

calebamiles
Copy link
Contributor

@calebamiles calebamiles commented Mar 22, 2017 •
edited by ethernetdan
Loading

What this PR does / why we need it:

  • vendored CNI plugins properly handle DEL on missing resources
  • update CNI version refs

Which issue this PR fixes

fixes #43488

Release note:

bumps CNI to version v0.5.1 where plugins properly handle DEL on non existent resources

Bump CNI consumers to latest version
f4d9bbc 
- vendored CNI plugins properly handle `DEL` on missing resources
- [based on v0.5.1](#43488 (comment))
@calebamiles calebamiles added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Mar 22, 2017
@calebamiles calebamiles added this to the v1.6 milestone Mar 22, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Mar 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@calebamiles calebamiles changed the title Bump CNI consumers to latest version Bump CNI consumers to v0.5.1 Mar 22, 2017
@calebamiles calebamiles added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Mar 22, 2017
@calebamiles
Copy link
Contributor Author

Someone from @kubernetes/sig-node-bugs or @kubernetes/sig-network-bugs please take a look. Thanks!

cc: @ethernetdan, @kubernetes/kubernetes-release-managers

@calebamiles calebamiles requested a review from bowei March 22, 2017 23:24
@feiskyer feiskyer mentioned this pull request Mar 22, 2017
Closed
@bowei
Copy link
Member

bowei commented Mar 23, 2017

@k8s-bot gci gce e2e test this

bowei
bowei reviewed Mar 23, 2017
View reviewed changes
Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for the test run to complete

@calebamiles
Copy link
Contributor Author

@dchen1107 please take a look. Thanks!

@bowei
Copy link
Member

bowei commented Mar 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2017
@ethernetdan
Copy link
Contributor

@lavalamp @wojtek-t could you PTAL at this release blocker?

ethernetdan
ethernetdan reviewed Mar 23, 2017
View reviewed changes
Copy link
Contributor

@ethernetdan ethernetdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowei have we tested the scripts are able to provision CNI correctly?

We were able to validate the fix with flannel but it was exercised with hyperkube.

@bowei
Copy link
Member

bowei commented Mar 23, 2017

I am doing manual checking now

@bowei
Copy link
Member

bowei commented Mar 23, 2017

I tested the new bridge and loopback plugins manually on a cluster and they work.

@yujuhong
Copy link
Contributor

LGTM

@thockin @dchen1107, ping for approval.

@dchen1107
Copy link
Member

/lgtm

Thanks for updating.

@dchen1107
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, calebamiles, dchen1107

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@bgrant0607 bgrant0607 mentioned this pull request Mar 23, 2017
Closed
4 tasks
@luxas
Copy link
Member

luxas commented Mar 23, 2017

The debs and rpms also have to be updated...

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6ed3bce into kubernetes:master Mar 23, 2017
@luxas luxas mentioned this pull request Mar 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethernetdan ethernetdan ethernetdan left review comments

@bowei bowei bowei approved these changes

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@bowei bowei

@dchen1107 dchen1107

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Many CNI Plugins don't properly support DEL
9 participants
@calebamiles @k8s-reviewable @bowei @ethernetdan @yujuhong @dchen1107 @k8s-github-robot @luxas @k8s-ci-robot