Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark kubelet's master-service-namespace flag deprecated #44250

Merged
merged 1 commit into from
May 12, 2017
Merged

Mark kubelet's master-service-namespace flag deprecated #44250

merged 1 commit into from
May 12, 2017

Conversation

mtaufen
Copy link
Contributor

@mtaufen mtaufen commented Apr 9, 2017

This flag is already deprecated in the API server:

It doesn't really make sense to adjust this on the Kubelet if you can't change it on the API server anymore.

Marks the Kubelet's --master-service-namespace flag deprecated

@mtaufen mtaufen added area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 9, 2017
@mtaufen mtaufen added this to the v1.7 milestone Apr 9, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 9, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@mtaufen mtaufen force-pushed the master-service-namespace branch 2 times, most recently from e13d401 to 0735367 Compare April 10, 2017 14:12
@Random-Liu
Copy link
Member

LGTM
@mtaufen PR needs rebase.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2017
@mtaufen
Copy link
Contributor Author

mtaufen commented May 12, 2017

Rebased

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2017
@mtaufen mtaufen added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2017
@mtaufen
Copy link
Contributor Author

mtaufen commented May 12, 2017

@wojtek-t please see for approval

@wojtek-t
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45653, 45719, 45729, 45730, 44250)

@k8s-github-robot k8s-github-robot merged commit f7892b1 into kubernetes:master May 12, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 12, 2017 •
edited
Loading

@mtaufen: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins kops AWS e2e 93f3922 link @k8s-bot kops aws e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SataQiu SataQiu mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Random-Liu Random-Liu

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mtaufen @k8s-reviewable @Random-Liu @wojtek-t @k8s-github-robot @k8s-ci-robot