Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few missing binaries to the Bazel SERVER_TARGETS list #44367

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Apr 11, 2017

What this PR does / why we need it: catches up our Bazel build with #41413 and #40204.

If you have clever ideas of how to keep the lists in build/release-tars/BUILD and hack/lib/golang.sh in sync I'd love hear them.

Release note:

NONE

/assign @spxtr @mikedanese

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mikedanese

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikedanese mikedanese added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 12, 2017
@spxtr
Copy link
Contributor

spxtr commented Apr 14, 2017

If you have clever ideas of how to keep the lists in build/release-tars/BUILD and hack/lib/golang.sh in sync I'd love hear them.

It's easy, just delete hack/lib/golang.sh.

@mikedanese mikedanese removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 14, 2017
@ixdy ixdy force-pushed the bazel-update-binary-lists branch from d94f92c to 73a7e34 Compare April 14, 2017 20:43
@ixdy
Copy link
Member Author

ixdy commented Apr 14, 2017

updated the vendored binary path.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2017
@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2017
@ixdy
Copy link
Member Author

ixdy commented Apr 14, 2017

@k8s-bot verify test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5dd9143 into kubernetes:master Apr 14, 2017
@k8s-ci-robot
Copy link
Contributor

@ixdy: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-cross 73a7e34 link @k8s-bot pull-kubernetes-cross test this
Jenkins GCI GCE e2e 73a7e34 link @k8s-bot gci gce e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ixdy ixdy deleted the bazel-update-binary-lists branch May 15, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants