Remove the old docker-multinode files that were built into the hyperkube image

[luxas]

What this PR does / why we need it:

ref: https://goo.gl/VxSaKx

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

The hyperkube image has been slimmed down and no longer includes addon manifests and other various scripts. These were introduced for the now removed docker-multinode setup system.

cc @jbeda @brendandburns @bgrant0607 @justinsb @mikedanese

[k8s-reviewable]

This change is 

[roberthbailey]

lgtm (not adding the slash to get relevant approvals before this gets merged)

[mikedanese]

lgtm as well

/approve

[luxas]

Cool, thanks! @jbeda is the last one to lgtm then before merge 👍

[jbeda]

This LGTM but is a bit scary.

I'd put a bit more in the release note. Something like "The hyperkube image has been slimmed down and no longer includes addon manifests and other various scripts. These were introduced for the now removed docker-multinode setup system."

/lgtm

[jbeda]

Sorry I didn't get this earlier! I thought I had covered all of these.

[luxas]

This LGTM but is a bit scary.

Yes, these were here only for the docker-multinode setup

The hyperkube image has been slimmed down and no longer includes addon manifests and other various scripts. These were introduced for the now removed docker-multinode setup system.

Proposal accepted ;)

Thanks!

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbeda, luxas, mikedanese

Needs approval from an approver in each of these OWNERS Files:

• cluster/OWNERS [jbeda,mikedanese]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue

[nikhiljindal]

I believe this PR broke federation build.

I see the following in logs:

I0420 10:48:18.314] make[1]: Entering directory '/var/lib/jenkins/workspace/ci-kubernetes-federation-build/go/src/k8s.io/kubernetes/cluster/images/hyperkube'
I0420 10:48:18.719] tar: /tmp/hyperkubeD9ftu6/cni-bin: Cannot open: No such file or directory
I0420 10:48:18.719] tar: Error is not recoverable: exiting now
I0420 10:48:18.720] curl: (23) Failed writing body (919 != 1379)
I0420 10:48:18.721] Makefile:62: recipe for target 'build' failed
I0420 10:48:18.721] make[1]: *** [build] Error 2
I0420 10:48:18.722] make[1]: Leaving directory '/var/lib/jenkins/workspace/ci-kubernetes-federation-build/go/src/k8s.io/kubernetes/cluster/images/hyperkube'
I0420 10:48:18.725] !!! [0420 10:48:18] Call tree:
I0420 10:48:18.727] !!! [0420 10:48:18]  1: ./develop/develop.sh:151 build_image(...)
I0420 10:48:18.727] !!! Error in ./develop/develop.sh:112
I0420 10:48:18.727]   Error in ./develop/develop.sh:112. '((i<3-1))' exited with status 2
I0420 10:48:18.727] Call stack:
I0420 10:48:18.727]   1: ./develop/develop.sh:112 build_image(...)
I0420 10:48:18.727]   2: ./develop/develop.sh:151 main(...)
I0420 10:48:18.727] Exiting with status 1
I0420 10:48:18.728] Makefile:50: recipe for target 'build_image' failed

Was removing cni-bin dir intentional?

[nikhiljindal]

Looks like there are other scripts relying on this cni-bin dir. Was removing this intentional?
It seems to have broken federation build.

[nikhiljindal]

Sent #44751 to fix the issue. Looking for someone in cluster/OWNERS to approve.