Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm #44635
What this PR does / why we need it:
This fixes the type of the ceph-secret secret that's created by the kubernetes-master charm.
Which issue this PR fixes (optional, in
Special notes for your reviewer:
Hi @Cynerva. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
This is +1 LGTM. I had no clue this was a schema type. looking at https://github.com/kubernetes/kubernetes/tree/master/examples/persistent-volume-provisioning i see this is clearly outlined. Thanks for the fix @Cynerva
[APPROVALNOTIFIER] This PR is APPROVED
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing