New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm #44635

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
8 participants
@Cynerva
Contributor

Cynerva commented Apr 18, 2017

What this PR does / why we need it:

This fixes the type of the ceph-secret secret that's created by the kubernetes-master charm.

Without the kubernetes.io/rbd type, automatic provisioning of PVCs doesn't work.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm
@k8s-reviewable

This comment has been minimized.

Show comment
Hide comment
@k8s-reviewable

k8s-reviewable Apr 18, 2017

This change is Reviewable

k8s-reviewable commented Apr 18, 2017

This change is Reviewable

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Apr 18, 2017

Contributor

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Contributor

k8s-ci-robot commented Apr 18, 2017

Hi @Cynerva. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Cynerva

This comment has been minimized.

Show comment
Hide comment
@Cynerva

Cynerva Apr 18, 2017

Contributor

/assign @chuckbutler

I believe you were around when our ceph operational code was originally added. Can you review this change?

Contributor

Cynerva commented Apr 18, 2017

/assign @chuckbutler

I believe you were around when our ceph operational code was originally added. Can you review this change?

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 18, 2017

Member

This is +1 LGTM. I had no clue this was a schema type. looking at https://github.com/kubernetes/kubernetes/tree/master/examples/persistent-volume-provisioning i see this is clearly outlined. Thanks for the fix @Cynerva

Member

lazypower commented Apr 18, 2017

This is +1 LGTM. I had no clue this was a schema type. looking at https://github.com/kubernetes/kubernetes/tree/master/examples/persistent-volume-provisioning i see this is clearly outlined. Thanks for the fix @Cynerva

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 18, 2017

Member

/approve

Member

lazypower commented Apr 18, 2017

/approve

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 18, 2017

Member

/lgtm

Member

lazypower commented Apr 18, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Apr 18, 2017

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 18, 2017

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, chuckbutler

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Contributor

k8s-merge-robot commented Apr 18, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cynerva, chuckbutler

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@lazypower

This comment has been minimized.

Show comment
Hide comment
@lazypower

lazypower Apr 19, 2017

Member

@k8s-bot unit test this

Member

lazypower commented Apr 19, 2017

@k8s-bot unit test this

@k8s-merge-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-merge-robot

k8s-merge-robot Apr 19, 2017

Contributor

Automatic merge from submit-queue

Contributor

k8s-merge-robot commented Apr 19, 2017

Automatic merge from submit-queue

@k8s-merge-robot k8s-merge-robot merged commit daeac53 into kubernetes:master Apr 19, 2017

12 of 13 checks passed

Submit Queue Required Github CI test is not green: Jenkins GCE etcd3 e2e
Details
Jenkins Bazel Build Job succeeded.
Details
Jenkins GCE Node e2e Jenkins job succeeded.
Details
Jenkins GCE e2e Jenkins job succeeded.
Details
Jenkins GCE etcd3 e2e Jenkins job succeeded.
Details
Jenkins GCI GCE e2e Jenkins job succeeded.
Details
Jenkins Kubemark GCE e2e Jenkins job succeeded.
Details
Jenkins kops AWS e2e Jenkins job succeeded.
Details
Jenkins non-CRI GCE Node e2e Jenkins job succeeded.
Details
Jenkins non-CRI GCE e2e Jenkins job succeeded.
Details
Jenkins unit/integration Jenkins job succeeded.
Details
Jenkins verification Jenkins job succeeded.
Details
cla/linuxfoundation Cynerva authorized
Details

@Cynerva Cynerva deleted the Cynerva:gkk/ceph-secret-type branch Apr 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment