I removed most of the unused arguments. But, There are a few methods still using the cmd argument. Namely, factory.Validator, PrintObject, PrinterForMapping and ClientMapperForCommand. Before proceeding any further I wanted to ask what should be done about these methods? Deprecated/Refactored/Removed ?

The factory methods were the most important. The pattern before was people using the flags by name (cmd.Flags().Get("foo")), but now factory methods must use pointer flag vars, so there's nothing that should need the command there.

The printer methods are optional units that can be used when you add the flags for them to your command. Unless we refactor the definition of those flags to use pointers and return a printer struct (something I had started a while back and never finished), it's not worth changing them right now.

The other consumer of factory is OpenShift - we wrap the factory to add our additional types (implementations of things like describers, action verbs, etc): https://github.com/openshift/origin/blob/master/pkg/cmd/util/clientcmd/factory.go - but we will pick up and remove use of cmd when we rebase.

On Mar 14, 2015, at 6:53 AM, Tamer TAS notifications@github.com wrote:

I removed most of the unused arguments. But, There are a few methods still using the cmd argument. Namely, factory.Validator, PrintObject, PrinterForMapping and ClientMapperForCommand. Before proceeding any further I wanted to ask what should be done about these methods? Deprecated/Refactored/Removed ?

—
Reply to this email directly or view it on GitHub.

Thanks for the explanation. I've cleaned the factory.Validation as well. Print method APIs are untouched as you suggested.

cc @krousey

Looks like this was done by PR #6144