Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds log when gpuManager.start() failed #44727

Merged
merged 1 commit into from May 8, 2017

Conversation

x1957
Copy link
Contributor

@x1957 x1957 commented Apr 20, 2017

If gpuManager.start() returns error, there is no log.

We confused with scheduler do not schedule any pod(with gpu) to one node.
kubectl describe node xxx shows there is no gpu on that node, because the gpu driver do not work on that node, gpuManager.start() failed, but we can not see anything in log.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @x1957. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2017
@cmluciano
Copy link

Possible dup of #44463

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 20, 2017
Copy link
Contributor

@xiangpengzhao xiangpengzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM:)

@xiangpengzhao
Copy link
Contributor

@cmluciano I find your that PR doesn't include what this PR does. Since that PR is WIP, did you ever plan to include this? :)

@cmluciano
Copy link

The linked PR does log here. It then retries the GPU initiate process in a go routine.

@vishh
Copy link
Contributor

vishh commented Apr 20, 2017

/lgtm
/approve

It's better to surface errors. I agree with @cmluciano. The issue might be that of parallel driver installation.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2017
@vishh vishh added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 20, 2017
@vishh
Copy link
Contributor

vishh commented Apr 20, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishh, x1957

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2017
@vishh
Copy link
Contributor

vishh commented Apr 20, 2017

Thanks for the patch @x1957

@x1957
Copy link
Contributor Author

x1957 commented Apr 21, 2017

@cmluciano nice work #

@x1957
Copy link
Contributor Author

x1957 commented Apr 25, 2017

@k8s-bot kops aws e2e test this

@xiangpengzhao
Copy link
Contributor

Submit Queue — PR is missing CLA label; needs one of cla: yes, cncf-cla: yes or cla: human-approved

@x1957 check your CLA status, please.

@x1957
Copy link
Contributor Author

x1957 commented May 3, 2017

@xiangpengzhao How to check CLA status? Thanks

@xiangpengzhao
Copy link
Contributor

cla/linuxfoundation — x1957 authorized This check shows that your CLA was ok. I don't know why the label was missed and how to check again. You may need @vishh to label it manually if your CLA signature can be confirmed.

@fejta any thoughts? Do we have some manual way to check and label cncf-cla:yes ?

@dankohn
Copy link
Contributor

dankohn commented May 3, 2017

@emsearcy I believe this may be an after-effect of the CLAbot bug from a couple weeks ago. Could you please trigger a re-run?

@x1957
Copy link
Contributor Author

x1957 commented May 4, 2017

@dankohn @emsearcy thanks

@emsearcy
Copy link

emsearcy commented May 4, 2017

@dankohn our CLA tool doesn't touch the labels: it's only responsible for the cla/linuxfoundation status check result. There is another Kubernetes-specific bot that uses the cla/linuxfoundation status to set labels.

@dankohn
Copy link
Contributor

dankohn commented May 4, 2017

@caniszczyk ???

@madhusudancs
Copy link
Contributor

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@foxish foxish added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2017
@foxish
Copy link
Contributor

foxish commented May 8, 2017

Added label manually. May have been a github glitch. The label automation is on our end. cc @kubernetes/test-infra-maintainers

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f4fc4be into kubernetes:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet