Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PodPreset in kubectl get command #44746

Merged
merged 1 commit into from May 10, 2017
Merged

Add support for PodPreset in kubectl get command #44746

merged 1 commit into from May 10, 2017

Conversation

xiangpengzhao
Copy link
Contributor

What this PR does / why we need it:
PR title

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #44736

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @xiangpengzhao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 21, 2017
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 21, 2017
@k8s-github-robot k8s-github-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 21, 2017
@xiangpengzhao xiangpengzhao mentioned this pull request Apr 21, 2017
Closed
@dims
Copy link
Member

dims commented Apr 24, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2017
@fabianofranz
Copy link
Contributor

@k8s-bot bazel test this
@k8s-bot verify test this

@bgrant0607 bgrant0607 added the sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. label Apr 26, 2017
@dims
Copy link
Member

dims commented May 1, 2017

@k8s-bot verify test this
@k8s-bot bazel test this
@k8s-bot non-cri e2e test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 5, 2017 •
edited

@xiangpengzhao: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins non-CRI GCE e2e f6c6fb6 link @k8s-bot non-cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member

dims commented May 5, 2017

/unassign @dims

@fabianofranz
Copy link
Contributor

@xiangpengzhao mind squashing the commits?

@xiangpengzhao
Copy link
Contributor Author

@fabianofranz squashed. PTAL. Thanks!

@fabianofranz
Copy link
Contributor

/lgtm
/approve
tks @xiangpengzhao!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, xiangpengzhao

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 148b5da into kubernetes:master May 10, 2017
@xiangpengzhao xiangpengzhao deleted the fix-podpreset branch May 10, 2017 04:24
@fabianofranz fabianofranz mentioned this pull request Jul 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PodPresets can't be enumerated by kubectl get podpreset
7 participants
@xiangpengzhao @k8s-reviewable @k8s-ci-robot @dims @fabianofranz @k8s-github-robot @bgrant0607