Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api #44784

caesarxuchao · 2017-04-21T21:11:36Z

Comments that will be addressed in followup PR:

fix import lines like clientv1 "k8s.io/api/core/v1"
fix import line "k8s.io/api/core/v1" that belongs to another import section
Export functions instead of making SchemeBuilder public. (Discussion in ThirdPartyResource example: added watcher example, code cleanup #45463 and Correct client-go TPR example type registration #45910)
generate clientset to staging/client-go, get rid of the copy.

What's moved:
types.go, constants for annotation keys, methods of the types, validation, defaults, generated swagger doc

What tests are passed:
Unit tests are passed

Next steps:

fix all the code generators (@MHBauer are you interested in helping fixing them?)

deepcopy-gen: i fixed it locally.
conversion-gen: fixed locally
client-gen
...

open PRs to move other api groups
disable the publish robot
merge all PRs
create the k8s.io/api repo for real, and starts
re-enable the publish robot

The schema of the API that are served by the kube-apiserver, together with a small amount of generated code, are moved to k8s.io/api (https://github.com/kubernetes/api).

k8s-reviewable · 2017-04-21T21:12:42Z

This change is

k8s-github-robot · 2017-04-21T21:13:34Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caesarxuchao
We suggest the following additional approver: @lavalamp

Needs approval from an approver in each of these OWNERS Files:

OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

Automatic merge from submit-queue Remove imports of k8s.io/client-go/pkg/api k8s.io/client-go/pkg/api will be eliminated by #44784, so we need to remove all imports of it. This PR is large, but mostly simple changes, like: * using constants defined in the v1 package instead of those in the internal package * using k8s.io/client-go/kubernetes/scheme.Codecs/Schemes instead of those in k8s.io/client-go/pkg/api * using `v1.SchemeGroupVersion` instead of `api.Registry.GroupOrDie(api.GroupName).GroupVersion` in tests * importing `k8s.io/kubernetes/pkg/api` instead of `k8s.io/client-go/pkg/api` if possible With this PR #45159, the only remaining imports of `k8s.io/client-go/pkg/api` are from k8s.io/metrics. ``` bash $ git grep "\"k8s.io/client-go/pkg/api\"" | grep -v "staging/src/k8s.io/client-go/pkg/api" staging/src/k8s.io/metrics/pkg/apis/custom_metrics/install/install.go:25: "k8s.io/client-go/pkg/api" Binary file staging/src/k8s.io/metrics/pkg/apis/custom_metrics/types.generated.go matches staging/src/k8s.io/metrics/pkg/apis/custom_metrics/types.go:22: "k8s.io/client-go/pkg/api" staging/src/k8s.io/metrics/pkg/apis/metrics/install/install.go:26: "k8s.io/client-go/pkg/api" staging/src/k8s.io/metrics/pkg/apis/metrics/types.go:21: "k8s.io/client-go/pkg/api" Binary file staging/src/k8s.io/metrics/pkg/apis/metrics/v1alpha1/zz_generated.conversion.go matches Binary file staging/src/k8s.io/metrics/pkg/apis/metrics/zz_generated.deepcopy.go matches staging/src/k8s.io/metrics/pkg/client/clientset_generated/clientset/fake/clientset_generated.go:24: "k8s.io/client-go/pkg/api" staging/src/k8s.io/metrics/pkg/client/custom_metrics/client.go:26: "k8s.io/client-go/pkg/api" staging/src/k8s.io/metrics/pkg/client/custom_metrics/fake/fake_client.go:24: "k8s.io/client-go/pkg/api" ```

k8s-ci-robot · 2017-05-10T03:24:05Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

caesarxuchao · 2017-05-11T01:10:51Z

make all && make test passed locally.

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move core API to pkg/apis/core Fixes #55304. This moves the types in pkg/api and most of pkg/api/v1 to pkg/apis/core to match the other api groups, following-up on what #44784 did for the external types. It's a nearly 100% mechanical package move with a number of trivial fixups in code-generators and in tests which do string comparisons of types via reflection. **Most importantly:** - group names are unchanged - apimachinery semantics are unchanged - the outside api is unchanged. Note that some packages for helpers are left in pkg/api/v1. Splitting them into helpers which belong tightly to the api and those which are not is left to follow-ups. @kubernetes/sig-api-machinery-pr-reviews

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move core API to pkg/apis/core Fixes kubernetes/kubernetes#55304. This moves the types in pkg/api and most of pkg/api/v1 to pkg/apis/core to match the other api groups, following-up on what kubernetes/kubernetes#44784 did for the external types. It's a nearly 100% mechanical package move with a number of trivial fixups in code-generators and in tests which do string comparisons of types via reflection. **Most importantly:** - group names are unchanged - apimachinery semantics are unchanged - the outside api is unchanged. Note that some packages for helpers are left in pkg/api/v1. Splitting them into helpers which belong tightly to the api and those which are not is left to follow-ups. @kubernetes/sig-api-machinery-pr-reviews Kubernetes-commit: dd9981d038012c120525c9e6df98b3beb3ef19e1

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move core API to pkg/apis/core Fixes kubernetes/kubernetes#55304. This moves the types in pkg/api and most of pkg/api/v1 to pkg/apis/core to match the other api groups, following-up on what kubernetes/kubernetes#44784 did for the external types. It's a nearly 100% mechanical package move with a number of trivial fixups in code-generators and in tests which do string comparisons of types via reflection. **Most importantly:** - group names are unchanged - apimachinery semantics are unchanged - the outside api is unchanged. Note that some packages for helpers are left in pkg/api/v1. Splitting them into helpers which belong tightly to the api and those which are not is left to follow-ups. @kubernetes/sig-api-machinery-pr-reviews

Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move core API to pkg/apis/core Fixes kubernetes/kubernetes#55304. This moves the types in pkg/api and most of pkg/api/v1 to pkg/apis/core to match the other api groups, following-up on what kubernetes/kubernetes#44784 did for the external types. It's a nearly 100% mechanical package move with a number of trivial fixups in code-generators and in tests which do string comparisons of types via reflection. **Most importantly:** - group names are unchanged - apimachinery semantics are unchanged - the outside api is unchanged. Note that some packages for helpers are left in pkg/api/v1. Splitting them into helpers which belong tightly to the api and those which are not is left to follow-ups. @kubernetes/sig-api-machinery-pr-reviews

This change is similar to kubernetes/kubernetes@f2d3220a (run root-rewrite-import-client-go-api-types, 2017-06-22, kubernetes/kubernetes#44784, v1.8.0-alpha.2) and it protects us from the eventual removal of k8s.io/client-go/pkg/api/v1 in kubernetes/kubernetes@ffe74d1f (run hack/update-staging-client-go, 2017-06-22, kubernetes/kubernetes#44784, v1.8.0-alpha.2).

caesarxuchao assigned lavalamp Apr 21, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 21, 2017

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2017

caesarxuchao force-pushed the move-api-types branch from 8a2ca70 to b4b2750 Compare April 21, 2017 21:13

This was referenced Apr 24, 2017

Udpates deepcopy-gen to allow input types being defined in a different pacakge kubernetes/gengo#47

Closed

Include leaderelection in client-go; #39173

Merged

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2017

This was referenced Apr 26, 2017

Remove imports of k8s.io/client-go/pkg/api #44523

Merged

Added v1.helper to client-go. #44896

Closed

caesarxuchao force-pushed the move-api-types branch from 7cfc1db to 0b2011c Compare April 28, 2017 17:21

This was referenced Apr 28, 2017

client-gen: create private registry in fake clientset #42095

Merged

HPA Controller: Use Custom Metrics API #41824

Merged

caesarxuchao force-pushed the move-api-types branch from b922529 to 6c91db5 Compare May 2, 2017 04:41

caesarxuchao force-pushed the move-api-types branch from 5bb7649 to 5cfffd6 Compare May 5, 2017 06:15

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 5, 2017

caesarxuchao force-pushed the move-api-types branch 2 times, most recently from b473c41 to 0998a06 Compare May 10, 2017 03:23

k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2017

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 10, 2017

caesarxuchao force-pushed the move-api-types branch 2 times, most recently from 3c10c2f to 0349f8a Compare May 11, 2017 01:03

This was referenced Jul 11, 2017

Cleanup the conversion of ObjectReference #48747

Closed

Remove duplicated import and wrong alias name of package k8s.io/api/core/v1 #48975

Closed

This was referenced Nov 7, 2017

Move core API to pkg/apis/core #53651

Merged

TEST-DEBUG: Move core API to pkg/apis/core #55323

Closed

dims pushed a commit to dims/kubernetes that referenced this pull request Feb 8, 2018

Merge pull request kubernetes#44784 from caesarxuchao/move-api-types

ce61ed1

Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api

nikhita mentioned this pull request Mar 2, 2021

hack/verify-description.sh: correctly look for versioned API types #99621

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api #44784

Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api #44784

caesarxuchao commented Apr 21, 2017 •

edited

Loading

k8s-reviewable commented Apr 21, 2017

k8s-github-robot commented Apr 21, 2017

k8s-ci-robot commented May 10, 2017

caesarxuchao commented May 11, 2017

Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api #44784

Create staging folder for repo k8s.io/api, move external API used by client-go to k8s.io/api #44784

Conversation

caesarxuchao commented Apr 21, 2017 • edited Loading

k8s-reviewable commented Apr 21, 2017

k8s-github-robot commented Apr 21, 2017

k8s-ci-robot commented May 10, 2017

caesarxuchao commented May 11, 2017

caesarxuchao commented Apr 21, 2017 •

edited

Loading