-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup resources after services/guestbook e2e tests. #4492
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,6 @@ function join() { | |
svcs_to_clean=() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not affected by your change, but for my own understanding, does anything ever actually get added to this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All created services get added to it. See line 74. |
||
function do_teardown() { | ||
local svc | ||
return | ||
for svc in "${svcs_to_clean[@]:+${svcs_to_clean[@]}}"; do | ||
stop_service "${svc}" | ||
done | ||
|
@@ -284,7 +283,7 @@ function verify_from_container() { | |
fi | ||
} | ||
|
||
trap "do_teardown" EXIT | ||
trap do_teardown EXIT | ||
|
||
# Get node IP addresses and pick one as our test point. | ||
detect-minions | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubectl -f can act on entire directories? I had no idea...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. It looks for file extensions that could be schemas and attempts to load them as resources (skipping if invalid schema).