Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump GLBC version to 0.9.3 #45055

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Bump GLBC version to 0.9.3 #45055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions cluster/saltbase/salt/l7-gcp/glbc.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
apiVersion: v1
kind: Pod
metadata:
name: l7-lb-controller-v0.9.2
name: l7-lb-controller-v0.9.3
namespace: kube-system
labels:
k8s-app: glbc
version: v0.9.2
version: v0.9.3
kubernetes.io/cluster-service: "true"
kubernetes.io/name: "GLBC"
spec:
terminationGracePeriodSeconds: 600
hostNetwork: true
containers:
- image: gcr.io/google_containers/glbc:0.9.2
- image: gcr.io/google_containers/glbc:0.9.3
livenessProbe:
httpGet:
path: /healthz
Expand Down Expand Up @@ -43,7 +43,7 @@ spec:
# TODO: split this out into args when we no longer need to pipe stdout to a file #6428
- sh
- -c
- '/glbc --verbose=true --default-backend-service=kube-system/default-http-backend --sync-period=600s --running-in-cluster=false --use-real-cloud=true --config-file-path=/etc/gce.conf --healthz-port=8086 1>>/var/log/glbc.log 2>&1'
- '/glbc --verbose=true --apiserver-host=http://localhost:8080 --default-backend-service=kube-system/default-http-backend --sync-period=600s --running-in-cluster=false --use-real-cloud=true --config-file-path=/etc/gce.conf --healthz-port=8086 1>>/var/log/glbc.log 2>&1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we no longer default to localhost except with kubectl, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, previously was using deprecated clientcmd.ClusterDefaults https://github.com/kubernetes/client-go/blob/670b68600ead2fdd5c835a9ff7239dda903640a6/tools/clientcmd/client_config.go#L49
This flag is identical to the one used for nginx ingress controller.

volumes:
- hostPath:
path: /etc/gce.conf
Expand Down