Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete comments in types.go #4541

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Remove obsolete comments in types.go #4541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 7 additions & 7 deletions pkg/api/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ type Port struct {
HostPort int `json:"hostPort,omitempty"`
// Required: This must be a valid port number, 0 < x < 65536.
ContainerPort int `json:"containerPort"`
// Optional: Supports "TCP" and "UDP". Defaults to "TCP".
// Required: Supports "TCP" and "UDP".
Protocol Protocol `json:"protocol,omitempty"`
// Optional: What host IP to bind the external port to.
HostIP string `json:"hostIP,omitempty"`
Expand Down Expand Up @@ -344,11 +344,11 @@ type Container struct {
LivenessProbe *Probe `json:"livenessProbe,omitempty"`
ReadinessProbe *Probe `json:"readinessProbe,omitempty"`
Lifecycle *Lifecycle `json:"lifecycle,omitempty"`
// Optional: Defaults to /dev/termination-log
// Required.
TerminationMessagePath string `json:"terminationMessagePath,omitempty"`
// Optional: Default to false.
Privileged bool `json:"privileged,omitempty"`
// Optional: Policy for pulling images for this container
// Required: Policy for pulling images for this container
ImagePullPolicy PullPolicy `json:"imagePullPolicy"`
// Optional: Capabilities for container.
Capabilities Capabilities `json:"capabilities,omitempty"`
Expand Down Expand Up @@ -532,7 +532,7 @@ type PodSpec struct {
Volumes []Volume `json:"volumes"`
Containers []Container `json:"containers"`
RestartPolicy RestartPolicy `json:"restartPolicy,omitempty"`
// Optional: Set DNS policy. Defaults to "ClusterFirst"
// Required: Set DNS policy.
DNSPolicy DNSPolicy `json:"dnsPolicy,omitempty"`
// NodeSelector is a selector which must be true for the pod to fit on a node
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
Expand Down Expand Up @@ -692,7 +692,7 @@ type ServiceSpec struct {
// proxied by this service.
Port int `json:"port"`

// Optional: Supports "TCP" and "UDP". Defaults to "TCP".
// Required: Supports "TCP" and "UDP".
Protocol Protocol `json:"protocol,omitempty"`

// This service will route traffic to pods having labels matching this selector. If empty or not present,
Expand All @@ -715,7 +715,7 @@ type ServiceSpec struct {
// Optional: If unspecified, the first port on the container will be used.
ContainerPort util.IntOrString `json:"containerPort,omitempty"`

// Optional: Supports "ClientIP" and "None". Used to maintain session affinity.
// Required: Supports "ClientIP" and "None". Used to maintain session affinity.
SessionAffinity AffinityType `json:"sessionAffinity,omitempty"`
}

Expand Down Expand Up @@ -1164,7 +1164,7 @@ type ContainerManifest struct {
Volumes []Volume `json:"volumes"`
Containers []Container `json:"containers"`
RestartPolicy RestartPolicy `json:"restartPolicy,omitempty"`
// Optional: Set DNS policy. Defaults to "ClusterFirst"
// Required: Set DNS policy.
DNSPolicy DNSPolicy `json:"dnsPolicy"`
}

Expand Down