Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing “Pod Injection Policy” with “Pod Preset” in the code documentation #45460

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/openapi-spec/swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -45948,7 +45948,7 @@
]
},
"io.k8s.kubernetes.pkg.apis.settings.v1alpha1.PodPresetSpec": {
"description": "PodPresetSpec is a description of a pod injection policy.",
"description": "PodPresetSpec is a description of a pod preset.",
"properties": {
"env": {
"description": "Env defines the collection of EnvVar to inject into containers.",
Expand Down
2 changes: 1 addition & 1 deletion api/swagger-spec/settings.k8s.io_v1alpha1.json
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@
},
"v1alpha1.PodPresetSpec": {
"id": "v1alpha1.PodPresetSpec",
"description": "PodPresetSpec is a description of a pod injection policy.",
"description": "PodPresetSpec is a description of a pod preset.",
"properties": {
"selector": {
"$ref": "v1.LabelSelector",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2473,7 +2473,7 @@ <h3 id="_v1_quobytevolumesource">v1.QuobyteVolumeSource</h3>
<div class="sect2">
<h3 id="_v1alpha1_podpresetspec">v1alpha1.PodPresetSpec</h3>
<div class="paragraph">
<p>PodPresetSpec is a description of a pod injection policy.</p>
<p>PodPresetSpec is a description of a pod preset.</p>
</div>
<table class="tableblock frame-all grid-all" style="width:100%; ">
<colgroup>
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/settings/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type PodPreset struct {
Spec PodPresetSpec
}

// PodPresetSpec is a description of a pod injection policy.
// PodPresetSpec is a description of a pod preset.
type PodPresetSpec struct {
// Selector is a label query over a set of resources, in this case pods.
// Required.
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/settings/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/apis/settings/v1alpha1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type PodPreset struct {
Spec PodPresetSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`
}

// PodPresetSpec is a description of a pod injection policy.
// PodPresetSpec is a description of a pod preset.
type PodPresetSpec struct {
// Selector is a label query over a set of resources, in this case pods.
// Required.
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/settings/v1alpha1/types_swagger_doc_generated.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (PodPresetList) SwaggerDoc() map[string]string {
}

var map_PodPresetSpec = map[string]string{
"": "PodPresetSpec is a description of a pod injection policy.",
"": "PodPresetSpec is a description of a pod preset.",
"selector": "Selector is a label query over a set of resources, in this case pods. Required.",
"env": "Env defines the collection of EnvVar to inject into containers.",
"envFrom": "EnvFrom defines the collection of EnvFromSource to inject into containers.",
Expand Down
10 changes: 5 additions & 5 deletions pkg/registry/settings/podpreset/strategy.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,21 @@ import (
"k8s.io/kubernetes/pkg/apis/settings/validation"
)

// podPresetStrategy implements verification logic for Pod Injection Policies.
// podPresetStrategy implements verification logic for Pod Presets.
type podPresetStrategy struct {
runtime.ObjectTyper
names.NameGenerator
}

// Strategy is the default logic that applies when creating and updating Pod Injection Policy objects.
// Strategy is the default logic that applies when creating and updating Pod Preset objects.
var Strategy = podPresetStrategy{api.Scheme, names.SimpleNameGenerator}

// NamespaceScoped returns true because all Pod Injection Policies need to be within a namespace.
// NamespaceScoped returns true because all Pod Presets need to be within a namespace.
func (podPresetStrategy) NamespaceScoped() bool {
return true
}

// PrepareForCreate clears the status of a Pod Injection Policy before creation.
// PrepareForCreate clears the status of a Pod Preset before creation.
func (podPresetStrategy) PrepareForCreate(ctx genericapirequest.Context, obj runtime.Object) {
pip := obj.(*settings.PodPreset)
pip.Generation = 1
Expand Down Expand Up @@ -82,7 +82,7 @@ func (podPresetStrategy) ValidateUpdate(ctx genericapirequest.Context, obj, old
return append(validationErrorList, updateErrorList...)
}

// AllowUnconditionalUpdate is the default update policy for Pod Injection Policy objects.
// AllowUnconditionalUpdate is the default update policy for Pod Preset objects.
func (podPresetStrategy) AllowUnconditionalUpdate() bool {
return true
}
Expand Down
2 changes: 1 addition & 1 deletion staging/src/k8s.io/client-go/pkg/apis/settings/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type PodPreset struct {
Spec PodPresetSpec
}

// PodPresetSpec is a description of a pod injection policy.
// PodPresetSpec is a description of a pod preset.
type PodPresetSpec struct {
// Selector is a label query over a set of resources, in this case pods.
// Required.
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ type PodPreset struct {
Spec PodPresetSpec `json:"spec,omitempty" protobuf:"bytes,2,opt,name=spec"`
}

// PodPresetSpec is a description of a pod injection policy.
// PodPresetSpec is a description of a pod preset.
type PodPresetSpec struct {
// Selector is a label query over a set of resources, in this case pods.
// Required.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (PodPresetList) SwaggerDoc() map[string]string {
}

var map_PodPresetSpec = map[string]string{
"": "PodPresetSpec is a description of a pod injection policy.",
"": "PodPresetSpec is a description of a pod preset.",
"selector": "Selector is a label query over a set of resources, in this case pods. Required.",
"env": "Env defines the collection of EnvVar to inject into containers.",
"envFrom": "EnvFrom defines the collection of EnvFromSource to inject into containers.",
Expand Down