Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LogPath for container status in CRI #45580

Merged
merged 2 commits into from
May 13, 2017
Merged

Add LogPath for container status in CRI #45580

merged 2 commits into from
May 13, 2017

Conversation

heartlock
Copy link
Contributor

@heartlock heartlock commented May 10, 2017 •
edited
Loading

In order to get log path of container from CRI runtime, we need to add LogPath to ContainerStatus in CRI.
@Random-Liu @feiskyer

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @heartlock. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels May 10, 2017
@Random-Liu
Copy link
Member

@heartlock We should also set the field in dockershim.

@Random-Liu
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2017
@Random-Liu Random-Liu added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 10, 2017
@feiskyer
Copy link
Member

/assign

@heartlock
Copy link
Contributor Author

heartlock commented May 11, 2017 •
edited
Loading

@Random-Liu @feiskyer Updated! add a commit to set LogPath in dockershim. Please have a look!

@feiskyer
Copy link
Member

LGTM.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2017
@feiskyer
Copy link
Member

ping @yujuhong for approval.

@heartlock heartlock mentioned this pull request May 11, 2017
Closed
@Random-Liu
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2017
@k8s-github-robot k8s-github-robot removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 13, 2017
@heartlock
add LogPath for container status in CRI Interface
c3b5226 
Signed-off-by: heartlock <21521209@zju.edu.cn>
@heartlock
set LogPath in dockershim
8e70234 
Signed-off-by: heartlock <21521209@zju.edu.cn>
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2017
@heartlock
Copy link
Contributor Author

ping @Random-Liu rebased! ready for review.

@Random-Liu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, feiskyer, heartlock

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 98b5e9d into kubernetes:master May 13, 2017
@Random-Liu Random-Liu mentioned this pull request Oct 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@feiskyer feiskyer

@sjpotter sjpotter

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@heartlock @k8s-reviewable @k8s-ci-robot @Random-Liu @feiskyer @k8s-github-robot @sjpotter @yujuhong