apiserver: add a webhook implementation of the audit backend #45919
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package audit | ||
|
|
||
| import ( | ||
| "k8s.io/apimachinery/pkg/util/errors" | ||
| auditinternal "k8s.io/apiserver/pkg/apis/audit" | ||
| ) | ||
|
|
||
| // Union returns an audit Backend which logs events to a set of backends. The returned | ||
| // Sink implementation blocks in turn for each call to ProcessEvents. | ||
| func Union(backends ...Backend) Backend { | ||
| if len(backends) == 1 { | ||
| return backends[0] | ||
| } | ||
| return union{backends} | ||
| } | ||
|
|
||
| type union struct { | ||
| backends []Backend | ||
| } | ||
|
|
||
| func (u union) ProcessEvents(events ...*auditinternal.Event) { | ||
| for _, backend := range u.backends { | ||
| backend.ProcessEvents(events...) | ||
| } | ||
| } | ||
|
|
||
| func (u union) Run(stopCh <-chan struct{}) error { | ||
| var funcs []func() error | ||
| for _, backend := range u.backends { | ||
| funcs = append(funcs, func() error { | ||
| return backend.Run(stopCh) | ||
| }) | ||
| } | ||
| return errors.AggregateGoroutines(funcs...) | ||
|
There was a problem hiding this comment. Run may start go routines and shouldn't block, so I would say these don't need to be started in parallel. It's a nice interface though, so maybe this doesn't matter... |
||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package audit | ||
|
|
||
| import ( | ||
| "strconv" | ||
| "testing" | ||
|
|
||
| "k8s.io/apimachinery/pkg/types" | ||
| auditinternal "k8s.io/apiserver/pkg/apis/audit" | ||
| ) | ||
|
|
||
| type fakeBackend struct { | ||
| events []*auditinternal.Event | ||
| } | ||
|
|
||
| func (f *fakeBackend) ProcessEvents(events ...*auditinternal.Event) { | ||
| f.events = append(f.events, events...) | ||
| } | ||
|
|
||
| func (f *fakeBackend) Run(stopCh <-chan struct{}) error { | ||
| return nil | ||
| } | ||
|
|
||
| func TestUnion(t *testing.T) { | ||
| backends := []Backend{ | ||
| new(fakeBackend), | ||
| new(fakeBackend), | ||
| new(fakeBackend), | ||
| } | ||
|
|
||
| b := Union(backends...) | ||
|
|
||
| n := 5 | ||
|
|
||
| var events []*auditinternal.Event | ||
| for i := 0; i < n; i++ { | ||
| events = append(events, &auditinternal.Event{ | ||
| AuditID: types.UID(strconv.Itoa(i)), | ||
| }) | ||
| } | ||
| b.ProcessEvents(events...) | ||
|
|
||
| for i, b := range backends { | ||
| // so we can inspect the underlying events. | ||
| backend := b.(*fakeBackend) | ||
|
|
||
| if got := len(backend.events); got != n { | ||
| t.Errorf("backend %d wanted %d events, got %d", i, n, got) | ||
| continue | ||
| } | ||
| for j, event := range backend.events { | ||
| wantID := types.UID(strconv.Itoa(j)) | ||
| if event.AuditID != wantID { | ||
| t.Errorf("backend %d event %d wanted id %s, got %s", i, j, wantID, event.AuditID) | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Union method added so users can enable both the audit log and webhook at the same time. Does this work or should we make them exclusive?
EDIT: also need to add unit tests for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Having stderr output and webhook in parallel will be quite common I guess.