Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #45852 #45989

Merged
merged 1 commit into from
May 18, 2017
Merged

Automated cherry pick of #45852 #45989

merged 1 commit into from
May 18, 2017

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented May 17, 2017

Cherry pick of #45852 on release-1.6.

#45852: Add subPath e2e: test permissions and when subPath pre-exists

@k8s-ci-robot
Copy link
Contributor

Hi @wongma7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 17, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2017
@k8s-github-robot
Copy link

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@wongma7
Copy link
Contributor Author

wongma7 commented May 17, 2017

@enisoc, this is the cherrypick of subpath e2es into release-1.6

@enisoc enisoc added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels May 17, 2017
@enisoc enisoc added this to the v1.6 milestone May 17, 2017
@enisoc
Copy link
Member

enisoc commented May 17, 2017

@k8s-bot ok to test

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, wongma7

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@enisoc
Copy link
Member

enisoc commented May 17, 2017

@wongma7 Are you working on the build failure? It looks like some extra imports are needed to make this cherrypick successfully.

@wongma7
Copy link
Contributor Author

wongma7 commented May 17, 2017

yes, doing so now. i'll verify that it builds locally before pushing

@wongma7 wongma7 force-pushed the automated-cherry-pick-of-#45852-upstream-release-1.6 branch from cf8ab77 to f9fe353 Compare May 17, 2017 21:07
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented May 17, 2017

@enisoc done, please readd lgtm

@enisoc enisoc added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented May 17, 2017

@k8s-bot kops aws e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2e13e2c into kubernetes:release-1.6 May 18, 2017
@enisoc enisoc mentioned this pull request May 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

@enisoc enisoc

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wongma7 @k8s-ci-robot @k8s-github-robot @enisoc @soltysh @saad-ali