Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test in descibe resourcequota #46178

Merged
merged 1 commit into from
May 26, 2017
Merged

add test in descibe resourcequota #46178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 39 additions & 0 deletions pkg/printers/internalversion/describe_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,3 +1423,42 @@ URL: http://localhost
}
}
}

func TestDescribeResourceQuota(t *testing.T) {
fake := fake.NewSimpleClientset(&api.ResourceQuota{
ObjectMeta: metav1.ObjectMeta{
Name: "bar",
Namespace: "foo",
},
Status: api.ResourceQuotaStatus{
Hard: api.ResourceList{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is odd to see request CPU/memory equal to resource CPU/memory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated it. this metrics is my test namespace quota.

api.ResourceName(api.ResourceCPU): resource.MustParse("1"),
api.ResourceName(api.ResourceLimitsCPU): resource.MustParse("2"),
api.ResourceName(api.ResourceLimitsMemory): resource.MustParse("2G"),
api.ResourceName(api.ResourceMemory): resource.MustParse("1G"),
api.ResourceName(api.ResourceRequestsCPU): resource.MustParse("1"),
api.ResourceName(api.ResourceRequestsMemory): resource.MustParse("1G"),
},
Used: api.ResourceList{
api.ResourceName(api.ResourceCPU): resource.MustParse("0"),
api.ResourceName(api.ResourceLimitsCPU): resource.MustParse("0"),
api.ResourceName(api.ResourceLimitsMemory): resource.MustParse("0G"),
api.ResourceName(api.ResourceMemory): resource.MustParse("0G"),
api.ResourceName(api.ResourceRequestsCPU): resource.MustParse("0"),
api.ResourceName(api.ResourceRequestsMemory): resource.MustParse("0G"),
},
},
})
c := &describeClient{T: t, Namespace: "foo", Interface: fake}
d := ResourceQuotaDescriber{c}
out, err := d.Describe("foo", "bar", printers.DescriberSettings{ShowEvents: true})
if err != nil {
t.Errorf("unexpected error: %v", err)
}
expectedOut := []string{"bar", "foo", "limits.cpu", "2", "limits.memory", "2G", "requests.cpu", "1", "requests.memory", "1G"}
for _, expected := range expectedOut {
if !strings.Contains(out, expected) {
t.Errorf("expected to find %q in output: %q", expected, out)
}
}
}