Address remaining TODOs in kube-proxy. #46201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-t
added
the
release-note-none
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
approved
|
@k8s-bot unit test this |
thockin
reviewed
May 22, 2017
| // to apply. | ||
| return true | ||
| } | ||
| return len(ecm.items) > 0 |
There was a problem hiding this comment.
I guess this works. I was thinking of the return as "did this update() cause a change", but this should be behaviorally equivalent at the end.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
@wojtek-t: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue |
knobunc
added a commit
to knobunc/origin
that referenced
this pull request
May 25, 2017
PR 46201 (kubernetes/kubernetes#46201) and others recently have changed the log level at which the complete iptables rules are printed out. They were at log level 3, and Kubernetes now logs them at 5. This brings us in sync with that.
knobunc
added a commit
to knobunc/origin
that referenced
this pull request
May 25, 2017
PR 46201 (kubernetes/kubernetes#46201) and others recently have changed the log level at which the complete iptables rules are printed out. They were at log level 3, and Kubernetes now logs them at 5. This brings us in sync with that. Fixes bug 14359 (openshift#14359)
knobunc
added a commit
to knobunc/origin
that referenced
this pull request
May 25, 2017
PR 46201 (kubernetes/kubernetes#46201) and others recently have changed the log level at which the complete iptables rules are printed out. They were at log level 3, and Kubernetes now logs them at 5. This brings us in sync with that. Fixes bug 1455655 (https://bugzilla.redhat.com/show_bug.cgi?id=1455655)
deads2k
pushed a commit
to deads2k/kubernetes
that referenced
this pull request
Jun 7, 2017
PR 46201 (kubernetes#46201) and others recently have changed the log level at which the complete iptables rules are printed out. They were at log level 3, and Kubernetes now logs them at 5. This brings us in sync with that. Fixes bug 1455655 (https://bugzilla.redhat.com/show_bug.cgi?id=1455655) :100644 100644 fc00c52003... c7da6fe180... M pkg/proxy/iptables/proxier.go
deads2k
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Jun 7, 2017
PR 46201 (kubernetes#46201) and others recently have changed the log level at which the complete iptables rules are printed out. They were at log level 3, and Kubernetes now logs them at 5. This brings us in sync with that. Fixes bug 1455655 (https://bugzilla.redhat.com/show_bug.cgi?id=1455655) :100644 100644 fc00c52003... c7da6fe180... M pkg/proxy/iptables/proxier.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup PR from the previous two.