Add a feature gate for Debug Containers #46261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
6 tasks
verb
force-pushed
the
pod-tshoot-feature-gate-1
branch
from
e355f80
to
9d7c587
Compare
Closed
verb
force-pushed
the
pod-tshoot-feature-gate-1
branch
from
9d7c587
to
5aee19e
Compare
1 task
verb
force-pushed
the
pod-tshoot-feature-gate-1
branch
from
5aee19e
to
807a5f9
Compare
|
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
2 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, verb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test pull-kubernetes-e2e-gce-etcd3 |
|
/retest
… |
|
Automatic merge from submit-queue (batch tested with PRs 47958, 46261, 46667, 47709, 47579) |
k8s-github-robot
pushed a commit
that referenced
this pull request
Jan 24, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add a container type to the runtime manager's container status **What this PR does / why we need it**: This is Step 1 of the "Debug Containers" feature proposed in #35584 and is hidden behind a feature gate. Debug containers exist as container status with no associated spec, so this new runtime label allows the kubelet to treat containers differently without relying on spec. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: cc #27140 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` **Integrating feedback**: - [x] Remove Type field in favor of a help method **Dependencies:** - [x] #46261 Feature gate for Debug Containers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds a feature gate for Debug Containers feature proposed in kubernetes/community#649. This feature requires changes to the kubelet, apiserver and kubectl which can be decoupled except for the gate.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: