Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove kubectl's dependence on schema file in pkg/api/validation. #46317

Merged
merged 1 commit into from
Aug 17, 2017
Merged

Remove kubectl's dependence on schema file in pkg/api/validation. #46317

merged 1 commit into from
Aug 17, 2017

Conversation

monopole
Copy link
Contributor

@monopole monopole commented May 23, 2017 •
edited

What this PR does / why we need it:

Makes functions in validation/schema.go private to kubectl,
further isolating kubectl. This move revealed a "hidden" dependence
(a dependence not expressed in a BUILD or make file) from a feature
level test in /hack/make-rules on a kubectl test data file. So this
PR also adds some BUILD rules around the relevant hack targets, to make the
dependence official. A later PR will move the kubectl aspect of this "hack"
test into a kubectl test directory. Leaving it in place for now after establishing
and "official" dependency, since moving the test beyond PR scope. The
test also depends on a small sh file in //cluster, which makes no sense.

Which issue this PR fixes

Part of a series of PRs to address kubernetes/community#598

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels May 23, 2017
@monopole
Copy link
Contributor Author

/assign @pwittrock

@monopole
Copy link
Contributor Author

/assign @lavalamp

Need API owner's approval.

Please approve to unblock kubectl isolation work :)

@monopole
Copy link
Contributor Author

looks like a test is annoyed by a moved data file. will fix tomorrow, but meantime feel free to approve given that the merge won't happen till this is fixed.

@monopole
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-unit test this

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 24, 2017
@monopole monopole force-pushed the kubectlValidator branch 2 times, most recently from ca728c9 to b7e015b Compare May 24, 2017 19:42
@pwittrock
Copy link
Member

FYI, there is a test failure

@monopole monopole force-pushed the kubectlValidator branch 3 times, most recently from 71c95a2 to 9a35c87 Compare May 25, 2017 21:55
@pwittrock
Copy link
Member

@k8s-bot pull-kubernetes-node-e2e test this

@monopole
Copy link
Contributor Author

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

@pwittrock
Copy link
Member

@k8s-bot pull-kubernetes-node-e2e test this

@pwittrock
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2017
@pwittrock
Copy link
Member

/approve

monopole added a commit to monopole/kubernetes that referenced this pull request May 30, 2017
@monopole
Add jregan to OWNERS for kubectl isolation work.
55473f4 
The kubectl decoupling project (kubernetes#598) requires many BUILD edits.

Even relatively simple PR's involve many OWNER files, e.g. kubernetes#46317 involves five.

We plan to script-generate some PRs, and those may involve _hundreds_ of BUILD files.

This project will take many PRs, and collecting all approvals for each
will be very time consuming.
@monopole monopole mentioned this pull request May 30, 2017
Merged
@monopole
Copy link
Contributor Author

monopole commented Jun 2, 2017 •
edited

/assign @mikedanese
for cluster/BUILD

/assign @ixdy
for build/BUILD

/assign @erictune
for pkg/api/BUILD

@monopole
Copy link
Contributor Author

/assign @apelisse

Antoine, PTAL, as this overlaps w/ your openapi work a bit.
all tests are passing

apelisse
apelisse approved these changes Aug 16, 2017
View reviewed changes
Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the lint-detected changes are super welcome.

Thanks for working on that, maybe I'd have liked a better separation of these multiples changes, but whatever

pkg/api/errors/BUILD Outdated
@@ -5,11 +5,6 @@ load(
"go_library",
)

go_library(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's unfortunate you have to do that...

pkg/api/validation/validation_test.go
@@ -32,6 +32,7 @@ import (
utilfeature "k8s.io/apiserver/pkg/util/feature"
"k8s.io/kubernetes/pkg/api"
"k8s.io/kubernetes/pkg/api/helper"
_ "k8s.io/kubernetes/pkg/api/testapi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think that answers my question from this morning.

@apelisse
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@monopole
Copy link
Contributor Author

/test pull-kubernetes-unit

@apelisse
Copy link
Member

Needs rebase :-/

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 16, 2017
@apelisse
Copy link
Member

@monopole Feel free to self-lgtm after rebase.

@monopole
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@monopole: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@monopole
Copy link
Contributor Author

@apelisse self-lgtm? https://github.com/kubernetes/test-infra/blob/master/prow/plugins/lgtm/lgtm.go#L173

@mengqiy
Copy link
Member

mengqiy commented Aug 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@monopole
Remove kubectl's dependence on schema file in pkg/api/validation.
dbc22ad 
**What this PR does / why we need it**:

Makes functions in validation/schema.go private to kubectl,
further isolating kubectl.

**Which issue this PR fixes**

Part of a series of PRs to address kubernetes/community#598

**Release note**:
```release-note
NONE
```
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@mengqiy
Copy link
Member

mengqiy commented Aug 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, ixdy, mengqiy, mikedanese, monopole, pwittrock

Associated issue: 598

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 225b911 into kubernetes:master Aug 17, 2017
@monopole monopole deleted the kubectlValidator branch October 27, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese mikedanese left review comments

@ixdy ixdy ixdy left review comments

@apelisse apelisse apelisse approved these changes

Assignees

@mikedanese mikedanese

@apelisse apelisse

@mengqiy mengqiy

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet