Fix standardFinalizers - add missing metav1.FinalizerDeleteDependents

[tnozicka]

What this PR does / why we need it:
It adds FinalizerDeleteDependents to standardFinalizers otherwise this finalizer is unusable because apiserver will fail validation because it is not fully qualified name - but it is a standard Kubernetes finalizer used by garbage collector but it can't be set.

It's sibling FinalizerOrphanDependents is already there. I suppose this is a bug because otherwise FinalizerDeleteDependents is unusable.

Fixes openshift/origin#14322
Might fix #45764

Not for the reviewer:
This same definition is also in staging. Does it get propagated to staging automatically? Editing the same file twice doesn't seem like the intended option.

Fix `Invalid value: "foregroundDeletion"` error when attempting to delete a resource.

[k8s-ci-robot]

Hi @tnozicka. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pwittrock]

@yujuhong kicking over to the node team

[caesarxuchao]

/lgtm

[caesarxuchao]

/release-note-none

[caesarxuchao]

You need to call the hack/update-staging-client-go.sh to update the staging code, otherwise the verification will fail. Since it's just one line, manually copy it would be easier.

[caesarxuchao]

@k8s-bot ok to test

[caesarxuchao]

I guess we didn't catch the bug because the finalizer is usually set via the DeleteOptions at the REST layer, which is not subject to validation.

[caesarxuchao]

/assign @lavalamp

[caesarxuchao]

/lgtm
/approve

[lavalamp]

/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, lavalamp, tnozicka

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/api/OWNERS [lavalamp]
• staging/src/k8s.io/client-go/pkg/api/OWNERS [caesarxuchao,lavalamp]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[tnozicka]

Flake #46853
@k8s-bot pull-kubernetes-e2e-kops-aws test this

@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-verify test this

[0xmichalis]

@k8s-bot pull-kubernetes-e2e-kops-aws test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this
@k8s-bot pull-kubernetes-verify test this

[caesarxuchao]

@k8s-bot pull-kubernetes-e2e-kops-aws test this

[caesarxuchao]

@k8s-bot pull-kubernetes-verify test this

[k8s-github-robot]

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

[caesarxuchao]

@k8s-bot pull-kubernetes-federation-e2e-gce test this

[k8s-ci-robot]

@tnozicka: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kops-aws	9ed01e4	link	@k8s-bot pull-kubernetes-e2e-kops-aws test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 46648, 46500, 46238, 46668, 46557)

[caesarxuchao]

It's in 1.7, but need to be backported to 1.6.

[caesarxuchao]

Sent #47994.

[k8s-cherrypick-bot]

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.