Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crd shortname #46511

Merged
merged 1 commit into from May 26, 2017
Merged

add crd shortname #46511

merged 1 commit into from May 26, 2017
+8 −0

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 26, 2017

Adds a shortname, crd, for CustomResourceDefinition.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels May 26, 2017
@ncdc
Copy link
Member

ncdc commented May 26, 2017

/assign

@ncdc
Copy link
Member

ncdc commented May 26, 2017

/release-note-none
/lgtm

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, ncdc

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8951bb6 into kubernetes:master May 26, 2017
@enisoc
Copy link
Member

enisoc commented May 26, 2017

Wow it's that easy? That's awesome!

@deads2k
Copy link
Contributor Author

deads2k commented May 26, 2017

Wow it's that easy? That's awesome!

Kudos to @p0lyn0mial. He did that work from storage, to types, to API, to CLI.

@enisoc enisoc mentioned this pull request May 26, 2017
Closed
@deads2k deads2k deleted the crd-04-short branch August 3, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@sttts sttts

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@deads2k @ncdc @k8s-github-robot @enisoc @sttts @k8s-ci-robot