Automated cherry pick of #45923

[verult]

Cherry pick of #45923 on release-1.6.

#45923: Node status updater now deletes the node entry in attach

[k8s-ci-robot]

Hi @verult. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-github-robot]

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

[verult]

/release-note-none

[enisoc]

@verult The original PR says this fixes "unnecessary node status updates". Can you elaborate on why this needs to be cherrypicked? Are the unnecessary status updates causing harm?

[verult]

@enisoc The unnecessary message is logged every 100ms, causing kube-controller-manager.log to get very large very quickly. The relevant issue is here: Issue #42438

[enisoc]

@verult Thanks.

/lgtm

@k8s-bot ok to test

[verult]

/assign @saad-ali

[verult]

@k8s-bot pull-kubernetes-verify test this

[verult]

@k8s-bot pull-kubernetes-verify test this

[jsafrane]

@verult, verify tests usually fails from a good reason, this time it's bazel check. And it includes hint what to do:

 I0608 13:29:05.626] Verifying hack/make-rules/../../hack/verify-bazel.sh
I0608 13:29:10.262] 23,25c23,25
I0608 13:29:10.262] <         "//vendor/github.com/golang/glog:go_default_library",
I0608 13:29:10.262] <         "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library",
I0608 13:29:10.263] <         "//vendor/k8s.io/apimachinery/pkg/util/strategicpatch:go_default_library",
I0608 13:29:10.263] ---
I0608 13:29:10.263] >         "//vendor:github.com/golang/glog",
I0608 13:29:10.263] >         "//vendor:k8s.io/apimachinery/pkg/api/errors",
I0608 13:29:10.263] >         "//vendor:k8s.io/apimachinery/pkg/util/strategicpatch",
W0608 13:29:10.363] DRY-RUN: wrote "pkg/controller/volume/attachdetach/statusupdater/BUILD"
W0608 13:29:10.608] 
W0608 13:29:10.608] 1 BUILD files not up-to-date.
I0608 13:29:10.708] 
I0608 13:29:10.709] Run ./hack/update-bazel.sh

So, run hack/update-bazel.sh, update the PR and that should be it.

[enisoc]

Hm the hack/update-bazel.sh script should not have added these lines. Is your git tree checked out into a directory structure that ends in */src/k8s.io/kubernetes? For now I think you can just revert this file and the PR should pass, but for the future you should figure out why the script did this in your environment.

[verult]

Turns out I had a kubernetes/ directory under KUBE_ROOT, possibly as build output. Removing that did the trick. Thanks!

[jsafrane]

/lgtm

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, jsafrane, verult

Associated issue: 45923

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/controller/volume/attachdetach/OWNERS [jsafrane]
• pkg/volume/util/operationexecutor/OWNERS [jsafrane]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue