Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed e2e test flake - ClusterDns - should create pod that uses dns #46785

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Fixed e2e test flake - ClusterDns - should create pod that uses dns #46785

merged 1 commit into from
Jun 16, 2017

Conversation

prateekgogia
Copy link
Contributor

What this PR does / why we need it:
String replaced in this test for example pod yaml (dns-frontend-pod.yaml) file is incorrect.

Which issue this PR fixes :
fixes #45915

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @prateekgogia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 1, 2017
@caseydavenport
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed release-note-label-needed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 1, 2017
@caseydavenport
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 1, 2017
@caseydavenport
Copy link
Member

Thanks @prateekgogia! This lgtm.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2017
@fejta
Copy link
Contributor

fejta commented Jun 1, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this
ref kubernetes/test-infra#2931

@fejta
Copy link
Contributor

fejta commented Jun 1, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this
ref: kubernetes/test-infra#2932

@0xmichalis 0xmichalis removed their assignment Jun 3, 2017
@caseydavenport
Copy link
Member

@k8s-bot pull-kubernetes-unit test this

@cmluciano
Copy link

/retest

@prateekgogia
Copy link
Contributor Author

@bowei ping

@caseydavenport
Copy link
Member

caseydavenport commented Jun 15, 2017

@bowei @dchen1107 can we get this test fix added to v1.7?

@bowei
Copy link
Member

bowei commented Jun 16, 2017

/approve

@bowei
Copy link
Member

bowei commented Jun 16, 2017

yes, looks ok for 1.7

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, caseydavenport, prateekgogia

Associated issue: 45915

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2017
@cmluciano cmluciano added this to the v1.7 milestone Jun 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b64aaca into kubernetes:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure cluster [895633...] failed 48 builds, 2 jobs, and 1 tests over 1 days
9 participants