Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for namespace #46906

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Add test case for namespace #46906

merged 1 commit into from
Jun 23, 2017

Conversation

zhangxiaoyu-zidif
Copy link
Contributor

What this PR does / why we need it:
Unit test case need add that when name is "".

Special notes for your reviewer:
refer to https://github.com/kubernetes/kubernetes/blob/master/pkg/kubectl/namespace.go#L74

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @zhangxiaoyu-zidif. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 3, 2017
@gyliu513
Copy link
Contributor

gyliu513 commented Jun 4, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 4, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-unit test this
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

5 similar comments
@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@fabianofranz
Copy link
Contributor

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@fabianofranz
Copy link
Contributor

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@fabianofranz
Copy link
Contributor

/lgtm
/approve no-issue
/area test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. area/test labels Jun 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabianofranz, zhangxiaoyu-zidif

Associated issue requirement bypassed by: fabianofranz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47403, 46646, 46906, 46527, 46792)

@k8s-github-robot k8s-github-robot merged commit 8ba08c9 into kubernetes:master Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabianofranz fabianofranz

@ericchiang ericchiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zhangxiaoyu-zidif @k8s-ci-robot @gyliu513 @fabianofranz @k8s-github-robot @ericchiang