Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gke-slow always fails] Defer DeleteGCEStaticIP before asserting error #46991

Merged
merged 1 commit into from Jun 7, 2017
Merged

[gke-slow always fails] Defer DeleteGCEStaticIP before asserting error #46991

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/service.go
View file
Open in desktop
Expand Up @@ -556,7 +556,6 @@ var _ = framework.KubeDescribe("Services", func() {
By("creating a static load balancer IP")
staticIPName = fmt.Sprintf("e2e-external-lb-test-%s", framework.RunId)
requestedIP, err = framework.CreateGCEStaticIP(staticIPName)
Expect(err).NotTo(HaveOccurred())
defer func() {
if staticIPName != "" {
// Release GCE static IP - this is not kube-managed and will not be automatically released.
Expand All @@ -565,6 +564,7 @@ var _ = framework.KubeDescribe("Services", func() {
}
}
}()
Expect(err).NotTo(HaveOccurred())
framework.Logf("Allocated static load balancer IP: %s", requestedIP)
}

Expand Down