-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node status updater now deletes the node entry in attach updates when… #47007
Node status updater now deletes the node entry in attach updates when… #47007
Conversation
… node is missing in NodeInformer cache. Fixes kubernetes#42438. - Added RemoveNodeFromAttachUpdates as part of node status updater operations.
Hi @verult. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @saad-ali |
/cc @jessfraz for 1.4 release approval. |
are we still updating 1.4? |
@jessfraz I wasn't sure either. I checked with @bgrant0607 and @shtatfeld, and apparently the policy is to support 2 releases before current release. And since current release is 1.6, 1.4 needs to be maintained until 1.7 is released at the end of month. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saad-ali, verult Associated issue: 42438 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot ok to test |
@k8s-bot pull-kubernetes-unit test this |
Automatic merge from submit-queue |
Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
What this PR does / why we need it: Fixes issue of unnecessary node status updates when node is deleted.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): cherry-pick of the fix for #42438