Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo in comments. #47166

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Fixed typo in comments. #47166

merged 1 commit into from
Jun 19, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Jun 8, 2017 •
edited by mtaufen

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # N/A

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 8, 2017
@k82cn
Copy link
Member Author

k82cn commented Jun 9, 2017

/retest

@mtaufen
Copy link
Contributor

mtaufen commented Jun 12, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2017
@mtaufen mtaufen added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 12, 2017
@mtaufen mtaufen added this to the v1.7 milestone Jun 12, 2017
@mtaufen
Copy link
Contributor

mtaufen commented Jun 12, 2017

/cc @vishh for approval

@marun marun added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 12, 2017
@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/retest

@vishh
Copy link
Contributor

vishh commented Jun 16, 2017

/lgtm
/approve

@k82cn
Copy link
Member Author

k82cn commented Jun 17, 2017

@vishh /approve no-issue , just a type.

@dchen1107
Copy link
Member

/lgtm

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, k82cn, mtaufen, vishh

Associated issue requirement bypassed by: dchen1107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46327, 47166)

k8s-github-robot pushed a commit that referenced this pull request Jun 19, 2017
Merge pull request #47166 from k82cn/type_fix
227f52e 
Automatic merge from submit-queue (batch tested with PRs 46327, 47166)

Fixed typo in comments.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # N/A

```release-note
NONE
```
@k8s-github-robot k8s-github-robot merged commit 227f52e into kubernetes:master Jun 19, 2017
@k82cn k82cn deleted the type_fix branch June 20, 2017 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtaufen mtaufen

@vishh vishh

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@k82cn @mtaufen @spiffxp @vishh @dchen1107 @k8s-github-robot @marun @k8s-ci-robot