AWS for cloud-controller-manager

[ublubu]

fixes #47214

This implements the NodeAddressesByProviderID and InstanceTypeByProviderID methods used by the cloud-controller-manager for the AWS provider.

NodeAddressesByProvider uses DescribeInstances (for normal addresses) and DescribeAddresses (for Elastic IP addresses).

InstanceTypeByProviderID uses DescribeInstances.

NONE

[k8s-ci-robot]

Hi @ublubu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wlan0]

This will cause OutOfIndex error.

[ublubu]

Oh whoops. Fixed it and added a test for this.

[wlan0]

@ublubu how was the kubelet obtaining node addresses before? Was it using the metadata service?

I'm asking because I'm wondering why there is a new function to describe addresses. Shouldn't there be existing methods for this very purpose?

[ublubu]

@wlan0 The kubelet uses the local metadata service.

In the kubelet:

kubernetes/pkg/kubelet/kubelet_node_status.go

Line 432 in b8c9ee8

nodeAddresses, err := instances.NodeAddresses(kl.nodeName)

AWS implementation of NodeAddresses using metadata service:

kubernetes/pkg/cloudprovider/providers/aws/aws.go

Line 940 in b8c9ee8

func (c *Cloud) NodeAddresses(name types.NodeName) ([]v1.NodeAddress, error) {

IIUC, the new methods are run in the CCM on a master, where a node's metadata service is not available.

[wlan0]

@ublubu The code looks good. Thanks for the PR!

LGTM

@thockin @luxas PTAL

[thockin]

@k8s-bot ok to test

[thockin]

/lgtm
/approve

@dchen1107 same question - 1.7.0 or 1.7.1?

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, ublubu

Associated issue: 47214

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/cloudprovider/OWNERS [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[wlan0]

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

[wlan0]

Addresses #47257

[thockin]

@k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

[luxas]

@thockin May I set the v1.7 label on this?
The risk (if any) seems to be really low...

[thockin]

@dchen1107 this is thoroughly flag gated already

[k8s-github-robot]

Automatic merge from submit-queue

[justinsb]

It seems this PR uses an incompatible provider id format.

[wlan0]

What should the format be?

[justinsb]

Addressed in #47395 I believe

[wlan0]

@justinsb Thanks!