Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hostconfig device map logic in dockershim. #47323

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

karataliu
Copy link
Contributor

What this PR does / why we need it:
Fixes for device injection logic in dockershim , please help verify e2e run.

Should do updateCreateConfig before Resources assignment.

Related change:
https://github.com/kubernetes/kubernetes/pull/46744/files#diff-c7dd39479fd733354254e70845075db5L137

Which issue this PR fixes
#47216

Special notes for your reviewer:

Release note:

@k8s-ci-robot
Copy link
Contributor

Hi @karataliu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 12, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jun 12, 2017
@cblecker
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 12, 2017
@rohitagarwal003
Copy link
Member

I can confirm that this fixes the failing GPU e2e tests.

@vishh Can you add milestone 1.7 to this?

@rohitagarwal003
Copy link
Member

Also add the release-note-node label.

@yujuhong yujuhong added this to the v1.7 milestone Jun 12, 2017
@yujuhong yujuhong assigned yujuhong and unassigned dims and tmrts Jun 12, 2017
@yujuhong yujuhong added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jun 12, 2017
@yujuhong
Copy link
Contributor

/lgtm

Need better unit tests, but merging this first to unblock the gpu tests.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2017
@vishh
Copy link
Contributor

vishh commented Jun 12, 2017

/approve
/lgtm

@vishh
Copy link
Contributor

vishh commented Jun 12, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karataliu, vishh, yujuhong

Associated issue: 47216

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@vishh vishh added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jun 12, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47000, 47188, 47094, 47323, 47124)

@k8s-github-robot k8s-github-robot merged commit b034a54 into kubernetes:master Jun 13, 2017
@karataliu karataliu deleted the dockershim branch June 13, 2017 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants