-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hostconfig device map logic in dockershim. #47323
Conversation
Hi @karataliu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot ok to test |
I can confirm that this fixes the failing GPU e2e tests. @vishh Can you add milestone 1.7 to this? |
Also add the release-note-node label. |
/lgtm Need better unit tests, but merging this first to unblock the gpu tests. |
/approve |
/approve no-issue |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karataliu, vishh, yujuhong Associated issue: 47216 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 47000, 47188, 47094, 47323, 47124) |
What this PR does / why we need it:
Fixes for device injection logic in dockershim , please help verify e2e run.
Should do updateCreateConfig before Resources assignment.
Related change:
https://github.com/kubernetes/kubernetes/pull/46744/files#diff-c7dd39479fd733354254e70845075db5L137
Which issue this PR fixes
#47216
Special notes for your reviewer:
Release note: