Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use echoserver:1.6 for better debugging and XSS prevention. #47683

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

rmmh
Copy link
Contributor

@rmmh rmmh commented Jun 16, 2017

What this PR does / why we need it: This updates our test code to use a newer echoserver with XSS preventions.

Which issue this PR fixes: fixes #47682

Special notes for your reviewer: Marking as 1.7 since it's a fix to test code.

Release note:

NONE

@rmmh rmmh added this to the v1.7 milestone Jun 16, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 16, 2017
@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2017
@nicksardo
Copy link
Contributor

x2 lgtm

@mikedanese
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, rmmh, spiffxp

Associated issue: 47682

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 47626, 47674, 47683, 47290, 47688)

@k8s-github-robot k8s-github-robot merged commit 354e6c2 into kubernetes:master Jun 17, 2017
@rmmh rmmh deleted the echoserver branch March 1, 2018 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Echoserver:1.4 triggers XSS warnings
7 participants