Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addons with upstream CVE fixes #47877

Merged
merged 6 commits into from
Jun 22, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jun 21, 2017

What this PR does / why we need it: refreshes the kube-dns, metadata-proxy, and fluentd-gcp, event-exporter, prometheus-to-sd, and ip-masq-agent addons with new base images containing fixes for the following vulnerabilities:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #47386 (yay!)

Special notes for your reviewer:

Release note:

Update kube-dns, metadata-proxy, and fluentd-gcp, event-exporter, prometheus-to-sd, and ip-masq-agent addons with new base images containing fixes for CVE-2016-4448, CVE-2016-9841, CVE-2016-9843,  CVE-2017-1000366, CVE-2017-2616, and CVE-2017-9526.

/assign @bowei @MrHohn @Q-Lee @crassirostris @dnardo
/cc @dchen1107 @timstclair

@ixdy ixdy added this to the v1.7 milestone Jun 21, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 21, 2017
@@ -46,11 +46,11 @@ spec:
containers:
# TODO: Add resources in 1.8
- name: event-exporter
image: gcr.io/google-containers/event-exporter:v0.1.0
image: gcr.io/google-containers/event-exporter:v0.1.0-r2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this is even used.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYM?

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ixdy
Copy link
Member Author

ixdy commented Jun 21, 2017

@MrHohn thanks! done.

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM for kube-dns

@dnardo
Copy link
Contributor

dnardo commented Jun 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2017
@bowei
Copy link
Member

bowei commented Jun 21, 2017

/lgtm

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 21, 2017
@ixdy
Copy link
Member Author

ixdy commented Jun 22, 2017

/retest

@ixdy
Copy link
Member Author

ixdy commented Jun 22, 2017

/assign @luxas @mikedanese

@crassirostris
Copy link

crassirostris commented Jun 22, 2017

Thanks!

/approve

@mikedanese
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, crassirostris, dnardo, ixdy, mikedanese

Associated issue: 47386

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit de4c381 into kubernetes:master Jun 22, 2017
5tefan added a commit to kubernetes-digitalocean-terraform/kubernetes-digitalocean-terraform that referenced this pull request Aug 22, 2017
* Updates kube-dns to latest

kube-dns was pretty out of date... latest version
includes CVE fixes [1].

Slightly modified from [2] to work here. Removed
serviceAccountName and strategy block.

Tested with the following command:
```
kubectl run -i --tty testdns --rm --restart=Never --image=busybox --command -- nslookup kubernetes.default
```

[1] kubernetes/kubernetes#47877
[2] https://github.com/kubernetes/kubernetes/tree/e633a1604f00908a1dcc898b206c3404db4d82ed/cluster/addons/dns

* Removes irrelevant kube-dns template comments
@ixdy ixdy deleted the update-1.7-images branch May 15, 2018 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update images before 1.7 release
10 participants