-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: Expose only the cluster-info ConfigMap in the kube-public ns #48050
Conversation
/lgtm but In order for it to get into 1.7 you need to talk with @kubernetes/sig-release-misc |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: luxas, timothysc Associated issue: 320 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Looks right. I'll approve the cherrypick. cc @dchen1107. |
Got lgtm and was approved by the release team. Adding the label |
Automatic merge from submit-queue |
@caesarxuchao Did this get cherrypicked? |
Sorry, no. Somehow i missed this one in the batch cherrypick. 1.7.1 ok? |
@caesarxuchao Let's do it by "best effort". If you still cherrypick, include, if not, v1.7.1 is fine. |
…#47875-#48050-#48261-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #47875 #48050 #48261 Cherry pick of #47875 #48050 #48261 on release-1.7. #47875: Implement e2e test for Stackdriver event exporter #48050: kubeadm: Expose only the cluster-info ConfigMap in the #48261: Fix removing finalizer for garbage collector
Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
What this PR does / why we need it:
Noticed a bug; we should only expose the
cluster-info
ConfigMap.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Fixes: kubernetes/kubeadm#320
Special notes for your reviewer:
Cherrypick-candidate for v1.8 cc @dchen1107
Not blocking the release though...
Release note:
@jbeda @pipejakob @timothysc @kubernetes/sig-cluster-lifecycle-pr-reviews