Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor podListEqual() #48473

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Refactor podListEqual() #48473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 11 additions & 11 deletions pkg/kubelet/preemption/preemption_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,21 +458,21 @@ func admissionRequirementListEqual(list1 admissionRequirementList, list2 admissi
return true
}

// this checks if the lists contents contain all of the same elements.
// this is not correct if there are duplicate pods in the list.
// for example: podListEqual([a, a, b], [a, b, b]) will return true
// podListEqual checks if the lists contents contain all of the same elements.
func podListEqual(list1 []*v1.Pod, list2 []*v1.Pod) bool {
if len(list1) != len(list2) {
return false
}
for _, a := range list1 {
contains := false
for _, b := range list2 {
if a == b {
contains = true
}
}
if !contains {

m := map[*v1.Pod]int{}
for _, val := range list1 {
m[val] = m[val] + 1
}
for _, val := range list2 {
m[val] = m[val] - 1
}
for _, v := range m {
if v != 0 {
return false
}
}
Expand Down