Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godep-save.sh: add workaround and more instructions #48685

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion hack/godep-save.sh
Expand Up @@ -52,6 +52,7 @@ pushd "${KUBE_ROOT}" > /dev/null
exit 1
fi

echo "Running godep save. This will take around 15 minutes."
GOPATH=${GOPATH}:${KUBE_ROOT}/staging godep save "${REQUIRED_BINS[@]}"

# create a symlink in vendor directory pointing to the staging client. This
Expand All @@ -63,4 +64,10 @@ pushd "${KUBE_ROOT}" > /dev/null
done
popd > /dev/null

echo "Don't forget to run hack/update-godep-licenses.sh if you added or removed a dependency!"
# Workaround broken symlink in docker repo because godep copies the link, but not the target
rm -rf ${KUBE_ROOT}/vendor/github.com/docker/docker/project/

echo
echo "Don't forget to run:"
echo "- hack/update-bazel.sh to recreate the BUILD files"
echo "- hack/update-godep-licenses.sh if you added or removed a dependency!"