Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SKIP_PUSH_GCS env so we can run without a push to GCS #4873

Merged
merged 1 commit into from
Feb 26, 2015
Merged

Add SKIP_PUSH_GCS env so we can run without a push to GCS #4873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions hack/jenkins/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ docker images -q | xargs -r docker rmi
# Build
go run ./hack/e2e.go -v --build

# Push to GCS
./build/push-ci-build.sh
[[ ${KUBE_SKIP_PUSH_GCS:-} =~ ^[yY]$ ]] || {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The more common pattern seems to be looking for "true" - any reason to prefer [yY] here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was copying KUBE_SKIP_CONFIRMATIONS, KUBE_GCS_UPLOAD_RELEASE etc, which seem to be common in the build scripts (e.g. build/common.sh)

Happy to switch to =="true" if you'd prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, we should do it all at once or not at all. I grepped but missed those

# Push to GCS
./build/push-ci-build.sh
}

sha256sum _output/release-tars/kubernetes*.tar.gz