Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up gce minNodesHealthCheckVersion due to known issues #49330

Merged
merged 1 commit into from Jul 21, 2017
Merged

Bump up gce minNodesHealthCheckVersion due to known issues #49330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/cloudprovider/providers/gce/gce_healthchecks.go
View file
Open in desktop
Expand Up @@ -37,8 +37,8 @@ var (
)

func init() {
if v, err := utilversion.ParseGeneric("1.7.0"); err != nil {
panic(err)
if v, err := utilversion.ParseGeneric("1.7.2"); err != nil {
glog.Fatalf("Failed to parse version for minNodesHealthCheckVersion: %v", err)
} else {
minNodesHealthCheckVersion = v
}
Expand Down
13 changes: 7 additions & 6 deletions pkg/cloudprovider/providers/gce/gce_healthchecks_test.go
View file
Open in desktop
Expand Up @@ -27,8 +27,9 @@ func TestIsAtLeastMinNodesHealthCheckVersion(t *testing.T) {
version string
expect bool
}{
{"v1.7.1", true},
{"v1.7.0-alpha.2.597+276d289b90d322", true},
{"v1.7.3", true},
{"v1.7.2", true},
{"v1.7.2-alpha.2.597+276d289b90d322", true},
{"v1.6.0-beta.3.472+831q821c907t31a", false},
{"v1.5.2", false},
}
Expand All @@ -52,14 +53,14 @@ func TestSupportsNodesHealthCheck(t *testing.T) {
{
Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.1",
KubeProxyVersion: "v1.7.2",
},
},
},
{
Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.0-alpha.2.597+276d289b90d322",
KubeProxyVersion: "v1.7.2-alpha.2.597+276d289b90d322",
},
},
},
Expand Down Expand Up @@ -92,14 +93,14 @@ func TestSupportsNodesHealthCheck(t *testing.T) {
{
Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.1",
KubeProxyVersion: "v1.7.3",
},
},
},
{
Status: v1.NodeStatus{
NodeInfo: v1.NodeSystemInfo{
KubeProxyVersion: "v1.7.0-alpha.2.597+276d289b90d322",
KubeProxyVersion: "v1.7.2-alpha.2.597+276d289b90d322",
},
},
},
Expand Down