Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix controller crash because of nil volume spec #49420

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Fix controller crash because of nil volume spec #49420

merged 1 commit into from
Jul 22, 2017

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jul 21, 2017 •
edited by saad-ali
Loading

For volumes that don't support bulk volume verification, a nil
volume spec can cause crash of controller.

Fixes #49418

Release note:

Fixes #49418 where kube-controller-manager can panic on volume.CanSupport methods and enter a crash loop.

@gnufied
Fix controller crash because of nil volume spec
0b1d61d 
For volumes that don't support bulk volume verifiction, a nil
volume spec can cause crash of controller.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2017
@gnufied
Copy link
Member Author

gnufied commented Jul 21, 2017

/sig storage

cc @saad-ali

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jul 21, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jul 21, 2017
@saad-ali saad-ali mentioned this pull request Jul 21, 2017
Closed
@gnufied
Copy link
Member Author

gnufied commented Jul 21, 2017

/test pull-kubernetes-kubemark-e2e-gce

@saad-ali
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2017
@saad-ali saad-ali added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Jul 22, 2017
@saad-ali saad-ali added this to the v1.7 milestone Jul 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, saad-ali

Associated issue: 49418

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@saad-ali
Copy link
Member

Added a release note.
@wojtek-t We need this cherry picked to next 1.7.x release.

@gnufied
Copy link
Member Author

gnufied commented Jul 22, 2017

/test pull-kubernetes-kubemark-e2e-gce

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 22, 2017 •
edited
Loading

@gnufied: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-etcd3 0b1d61d link /test pull-kubernetes-e2e-gce-etcd3

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 49420, 49296, 49299, 49371, 46514)

@k8s-github-robot k8s-github-robot merged commit ab35df5 into kubernetes:master Jul 22, 2017
@gnufied gnufied mentioned this pull request Jul 23, 2017
Merged
@wojtek-t wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 25, 2017
k8s-github-robot pushed a commit that referenced this pull request Jul 25, 2017
Merge pull request #49455 from gnufied/automated-cherry-pick-of-#4942…
8a11267 
…0-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #49420

Cherry pick of #49420 on release-1.7.

#49420: Fix controller crash because of nil volume spec
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@saad-ali saad-ali

@jingxu97 jingxu97

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gnufied @saad-ali @k8s-github-robot @k8s-ci-robot @k8s-cherrypick-bot @thockin @wojtek-t @jingxu97