Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix incorrect call to 'bind' in scheduler #50028
I previously submitted #49661 -- I'm not sure if that PR is too big or what, but this is an attempt at a smaller PR that makes progress on the same issue and is easier to review.
What this PR does / why we need it:
In this refactor (ecb962e#diff-67f2b61521299ca8d8687b0933bbfb19R223) the scheduler code was refactored into separate
This is an issue (and causes #49314, where pods that fail to bind to a node get stuck indefinitely) in the following scenario:
In this PR I've fixed the call to
Which issue this PR fixes: fixes #49314
Special notes for your reviewer:
Hi @julia-stripe. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
I understand the commands that are listed here.
referenced this pull request
Aug 3, 2017
From the original issue description, it is a serial regression for 1.7 release, and we should patch it. I marked this pr for cherrypick-candidate.
Aug 3, 2017
[APPROVALNOTIFIER] This PR is APPROVED
Associated issue: 49314
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing