Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved node/testutil to upper dir. #50179

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Moved node/testutil to upper dir. #50179

merged 1 commit into from
Aug 8, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Aug 4, 2017

What this PR does / why we need it:
Moved node/testutil to upper directory (pkg/controller); it's used by several controllers, and we need to test some helper func in pkg/controller.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): part of #49522

Release note:

N/A

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2017
@k82cn
Copy link
Member Author

k82cn commented Aug 5, 2017

/retest

1 similar comment
@k82cn
Copy link
Member Author

k82cn commented Aug 5, 2017

/retest

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 5, 2017
@k82cn
Copy link
Member Author

k82cn commented Aug 5, 2017

/retest

@k82cn k82cn mentioned this pull request Aug 5, 2017
Merged
@k82cn
Copy link
Member Author

k82cn commented Aug 6, 2017

/retest

@gmarek
Copy link
Contributor

gmarek commented Aug 7, 2017

@k82cn - please fix golint.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2017
@gmarek
Copy link
Contributor

gmarek commented Aug 7, 2017

@k82cn - golint still fails

@k82cn
Copy link
Member Author

k82cn commented Aug 7, 2017

ops, failed again :(. I will check the detail when proxy is up (golint is ok in my laptop.).

@gmarek
Copy link
Contributor

gmarek commented Aug 7, 2017

That's exactly the problem:

[0;31mFAILED�[0m   hack/make-rules/../../hack/verify-golint.sh	61s
I0807 11:44:52.007] Verifying hack/make-rules/../../hack/verify-govet.sh
W0807 11:44:52.108] Some packages in hack/.golint_failures do not exist anymore. Please remove them.
W0807 11:44:52.108] 
W0807 11:44:52.108]   pkg/controller/node/testutil

:)

@k82cn k82cn force-pushed the mv_node_testutils branch 2 times, most recently from f86650c to b14f2d7 Compare August 8, 2017 01:16
@k82cn
Copy link
Member Author

k82cn commented Aug 8, 2017

/retest

@k82cn
Copy link
Member Author

k82cn commented Aug 8, 2017

/retest

@k82cn
Copy link
Member Author

k82cn commented Aug 8, 2017

aha, green now !

@gmarek
Copy link
Contributor

gmarek commented Aug 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Aug 8, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, k82cn, wojtek-t

Associated issue: 49522

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 50254, 50174, 50179)

@k8s-github-robot k8s-github-robot merged commit 6b99a00 into kubernetes:master Aug 8, 2017
@k82cn k82cn deleted the mv_node_testutils branch August 8, 2017 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@aveshagarwal aveshagarwal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k82cn @gmarek @wojtek-t @k8s-github-robot @aveshagarwal @k8s-ci-robot