-
Notifications
You must be signed in to change notification settings - Fork 38.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support iscsi volume attach and detach #50334
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,213 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package iscsi | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "strconv" | ||
| "time" | ||
|
|
||
| "github.com/golang/glog" | ||
| "k8s.io/api/core/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "k8s.io/kubernetes/pkg/util/mount" | ||
| "k8s.io/kubernetes/pkg/volume" | ||
| volumeutil "k8s.io/kubernetes/pkg/volume/util" | ||
| ) | ||
|
|
||
| type iscsiAttacher struct { | ||
| host volume.VolumeHost | ||
| manager diskManager | ||
| } | ||
|
|
||
| var _ volume.Attacher = &iscsiAttacher{} | ||
|
|
||
| var _ volume.AttachableVolumePlugin = &iscsiPlugin{} | ||
|
|
||
| func (plugin *iscsiPlugin) NewAttacher() (volume.Attacher, error) { | ||
| return &iscsiAttacher{ | ||
| host: plugin.host, | ||
| manager: &ISCSIUtil{}, | ||
| }, nil | ||
| } | ||
|
|
||
| func (plugin *iscsiPlugin) GetDeviceMountRefs(deviceMountPath string) ([]string, error) { | ||
| mounter := plugin.host.GetMounter(iscsiPluginName) | ||
| return mount.GetMountRefs(mounter, deviceMountPath) | ||
| } | ||
|
|
||
| func (attacher *iscsiAttacher) Attach(spec *volume.Spec, nodeName types.NodeName) (string, error) { | ||
| return "", nil | ||
| } | ||
|
|
||
| func (attacher *iscsiAttacher) VolumesAreAttached(specs []*volume.Spec, nodeName types.NodeName) (map[*volume.Spec]bool, error) { | ||
| volumesAttachedCheck := make(map[*volume.Spec]bool) | ||
| for _, spec := range specs { | ||
| volumesAttachedCheck[spec] = true | ||
| } | ||
|
|
||
| return volumesAttachedCheck, nil | ||
| } | ||
|
|
||
| func (attacher *iscsiAttacher) WaitForAttach(spec *volume.Spec, devicePath string, pod *v1.Pod, timeout time.Duration) (string, error) { | ||
| mounter, err := attacher.volumeSpecToMounter(spec, attacher.host, pod) | ||
| if err != nil { | ||
| glog.Warningf("failed to get iscsi mounter: %v", err) | ||
| return "", err | ||
| } | ||
| return attacher.manager.AttachDisk(*mounter) | ||
| } | ||
|
|
||
| func (attacher *iscsiAttacher) GetDeviceMountPath( | ||
| spec *volume.Spec) (string, error) { | ||
| mounter, err := attacher.volumeSpecToMounter(spec, attacher.host, nil) | ||
| if err != nil { | ||
| glog.Warningf("failed to get iscsi mounter: %v", err) | ||
| return "", err | ||
| } | ||
| if mounter.InitiatorName != "" { | ||
| // new iface name is <target portal>:<volume name> | ||
| mounter.Iface = mounter.Portals[0] + ":" + mounter.VolName | ||
| } | ||
| return attacher.manager.MakeGlobalPDName(*mounter.iscsiDisk), nil | ||
| } | ||
|
|
||
| func (attacher *iscsiAttacher) MountDevice(spec *volume.Spec, devicePath string, deviceMountPath string) error { | ||
| mounter := attacher.host.GetMounter(iscsiPluginName) | ||
| notMnt, err := mounter.IsLikelyNotMountPoint(deviceMountPath) | ||
| if err != nil { | ||
| if os.IsNotExist(err) { | ||
| if err := os.MkdirAll(deviceMountPath, 0750); err != nil { | ||
| return err | ||
| } | ||
| notMnt = true | ||
| } else { | ||
| return err | ||
| } | ||
| } | ||
| volumeSource, readOnly, err := getVolumeSource(spec) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| options := []string{} | ||
| if readOnly { | ||
| options = append(options, "ro") | ||
| } | ||
| if notMnt { | ||
| diskMounter := &mount.SafeFormatAndMount{Interface: mounter, Exec: attacher.host.GetExec(iscsiPluginName)} | ||
| mountOptions := volume.MountOptionFromSpec(spec, options...) | ||
| err = diskMounter.FormatAndMount(devicePath, deviceMountPath, volumeSource.FSType, mountOptions) | ||
| if err != nil { | ||
| os.Remove(deviceMountPath) | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| type iscsiDetacher struct { | ||
| host volume.VolumeHost | ||
| mounter mount.Interface | ||
| manager diskManager | ||
| } | ||
|
|
||
| var _ volume.Detacher = &iscsiDetacher{} | ||
|
|
||
| func (plugin *iscsiPlugin) NewDetacher() (volume.Detacher, error) { | ||
| return &iscsiDetacher{ | ||
| host: plugin.host, | ||
| mounter: plugin.host.GetMounter(iscsiPluginName), | ||
| manager: &ISCSIUtil{}, | ||
| }, nil | ||
| } | ||
|
|
||
| func (detacher *iscsiDetacher) Detach(deviceMountPath string, nodeName types.NodeName) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (detacher *iscsiDetacher) UnmountDevice(deviceMountPath string) error { | ||
| unMounter := detacher.volumeSpecToUnmounter(detacher.mounter) | ||
| err := detacher.manager.DetachDisk(*unMounter, deviceMountPath) | ||
| if err != nil { | ||
| return fmt.Errorf("iscsi: failed to detach disk: %s\nError: %v", deviceMountPath, err) | ||
| } | ||
| glog.V(4).Infof("iscsi: successfully detached disk: %s", deviceMountPath) | ||
| return nil | ||
| } | ||
|
|
||
| func (attacher *iscsiAttacher) volumeSpecToMounter(spec *volume.Spec, host volume.VolumeHost, pod *v1.Pod) (*iscsiDiskMounter, error) { | ||
| var secret map[string]string | ||
| var bkportal []string | ||
| iscsi, readOnly, err := getVolumeSource(spec) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // Obtain secret for AttachDisk | ||
| if iscsi.SecretRef != nil && pod != nil { | ||
| if secret, err = volumeutil.GetSecretForPod(pod, iscsi.SecretRef.Name, host.GetKubeClient()); err != nil { | ||
| glog.Errorf("Couldn't get secret from %v/%v", pod.Namespace, iscsi.SecretRef) | ||
| return nil, err | ||
| } | ||
| } | ||
| lun := strconv.Itoa(int(iscsi.Lun)) | ||
| portal := portalMounter(iscsi.TargetPortal) | ||
| bkportal = append(bkportal, portal) | ||
| for _, tp := range iscsi.Portals { | ||
| bkportal = append(bkportal, portalMounter(string(tp))) | ||
| } | ||
| iface := iscsi.ISCSIInterface | ||
| exec := attacher.host.GetExec(iscsiPluginName) | ||
| var initiatorName string | ||
| if iscsi.InitiatorName != nil { | ||
| initiatorName = *iscsi.InitiatorName | ||
| } | ||
|
|
||
| return &iscsiDiskMounter{ | ||
| iscsiDisk: &iscsiDisk{ | ||
| plugin: &iscsiPlugin{ | ||
| host: host, | ||
| }, | ||
| VolName: spec.Name(), | ||
| Portals: bkportal, | ||
| Iqn: iscsi.IQN, | ||
| lun: lun, | ||
| Iface: iface, | ||
| chap_discovery: iscsi.DiscoveryCHAPAuth, | ||
| chap_session: iscsi.SessionCHAPAuth, | ||
| secret: secret, | ||
| InitiatorName: initiatorName, | ||
| manager: &ISCSIUtil{}}, | ||
| fsType: iscsi.FSType, | ||
| readOnly: readOnly, | ||
| mounter: &mount.SafeFormatAndMount{Interface: host.GetMounter(iscsiPluginName), Exec: exec}, | ||
| exec: exec, | ||
| deviceUtil: volumeutil.NewDeviceHandler(volumeutil.NewIOHandler()), | ||
| }, nil | ||
| } | ||
|
|
||
| func (detacher *iscsiDetacher) volumeSpecToUnmounter(mounter mount.Interface) *iscsiDiskUnmounter { | ||
| exec := detacher.host.GetExec(iscsiPluginName) | ||
| return &iscsiDiskUnmounter{ | ||
| iscsiDisk: &iscsiDisk{ | ||
| plugin: &iscsiPlugin{}, | ||
| }, | ||
| mounter: mounter, | ||
| exec: exec, | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all checks return true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jingxu97
Since iSCSI plugin doesn't have a way to confirm whether the volume is attached or not from outside of the kubelet node, we think this method needs to return true always. This is similar to the FC plugin attacher/detacher implementation.