Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more-specific arm32v7 instead of deprecated armhf organization #50616

Closed
wants to merge 1 commit into from

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Aug 14, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #50618

Special notes for your reviewer:
/assign @mkumatag @ixdy @luxas

Release note:

use more-specific arm32v7 instead of deprecated armhf organization

@k8s-ci-robot
Copy link
Contributor

@dixudx: GitHub didn't allow me to assign the following users: mkumatag.

Note that only kubernetes members can be assigned.

In response to this:

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
/assign @mkumatag @ixdy @luxas

Release note:

use more-specific arm32v7 instead of deprecated armhf organization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dixudx
We suggest the following additional approver: zmerlynn

Assign the PR to them by writing /assign @zmerlynn in a comment when ready.

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 14, 2017

/cc @mkumatag
PTAL. Thanks

@k8s-ci-robot
Copy link
Contributor

@dixudx: GitHub didn't allow me to request PR reviews from the following users: mkumatag.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mkumatag
PTAL. Thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the armel images in build/common.sh as well to arm32v7. They should have been armhf, I seem to have missed those.

Also look if you can find other armel to replace.

@luxas luxas added this to the v1.8 milestone Aug 14, 2017
@luxas
Copy link
Member

luxas commented Aug 14, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 14, 2017
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to regenerate the docker image with new base as armhf/debian:jessie is kind of a stale image older than 3 months.

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2017
@dixudx
Copy link
Member Author

dixudx commented Aug 14, 2017

@luxas @ixdy Any comments on the above suggestions from @mkumatag

@dixudx
Copy link
Member Author

dixudx commented Aug 15, 2017

/retest

@dixudx
Copy link
Member Author

dixudx commented Aug 16, 2017

/test pull-kubernetes-cross

@dixudx
Copy link
Member Author

dixudx commented Aug 19, 2017

Bumped a new version in PR #50602.

@luxas
Copy link
Member

luxas commented Aug 21, 2017

Closing in favor of #50602

@luxas luxas closed this Aug 21, 2017
@dixudx dixudx deleted the user_arm32v7_instead_armhf branch September 9, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The armhf organization is deprecated in favor of the more-specific arm32v7 organizations
6 participants